Skip to content

lib-manager: check for invalid module instance count #10927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Jun 17, 2026
+4 −1
Merged

lib-manager: check for invalid module instance count #10927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/library_manager/lib_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,10 @@ void lib_manager_get_instance_bss_address(uint32_t instance_id,
const struct sof_man_module *mod,
void __sparse_cache **va_addr, size_t *size)
{
*size = mod->segment[SOF_MAN_SEGMENT_BSS].flags.r.length / mod->instance_max_count *
/* mod->instance_max_count should never be 0, assume 1 if that happens */
unsigned int inst_cnt = mod->instance_max_count ? : 1;
Comment thread
lyakh marked this conversation as resolved.

*size = mod->segment[SOF_MAN_SEGMENT_BSS].flags.r.length / inst_cnt *
Comment thread
lyakh marked this conversation as resolved.
PAGE_SZ;
size_t inst_offset = *size * instance_id;
*va_addr = (void __sparse_cache *)(mod->segment[SOF_MAN_SEGMENT_BSS].v_base_addr +
Expand Down
Loading