Conversation
What was broken Long assignment labels in the Flexi-Talent member detail view extended beyond the card boundary. Root cause The detail label inherited no-wrap pill styling and had no maximum width, so its intrinsic width could exceed the detail pane. What was changed Constrained the detail label to the card width and allowed normal wrapping, including breaks within long unbroken values. Any added/updated tests Added a MembersView stylesheet regression test covering the width and wrapping rules for long assignment labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Long assignment labels in the Flexi-Talent member detail view extended beyond the card boundary.
Root cause
The detail label inherited no-wrap pill styling and had no maximum width, so its intrinsic width could exceed the detail pane.
What was changed
Constrained the detail label to the card width and allowed normal wrapping, including breaks within long unbroken values.
Any added/updated tests
Added a MembersView stylesheet regression test covering the width and wrapping rules for long assignment labels.
The focused MembersView suite passes with 2 tests, lint passes, and the production build passes. The full repository run completed with 163 suites passing and 10 unrelated existing Work and Wallet suites failing; the changed Flexi-Talent suite passed in that run.