🧪 Add tests for summarizeToolResult#33
Conversation
This commit introduces comprehensive unit tests for the `summarizeToolResult` function in `src/tui/lib/toolSummary.ts`. The new tests cover various scenarios including: - undefined and empty inputs - invalid JSON fallbacks - all explicit cases within the switch block (e.g., market_quote, portfolio_list, macro_indices) - fallback formatting for unknown tools This change improves test coverage and helps prevent regressions in the TUI summarization logic. Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What:
Added a comprehensive test suite (
tests/toolSummary.test.ts) for thesummarizeToolResultfunction insrc/tui/lib/toolSummary.tsto address a testing gap.📊 Coverage:
The new tests cover all branches within the switch statement, including:
market_quotemarket_ohlcvtechnical_indicatorsfundamentals_snapshotticker_newsforeign_flowmacro_indicesdiscover_tickersbroker_stateportfolio_listaccount_historyAdditionally, they cover missing/invalid input cases and default fallback truncation.
✨ Result:
Test coverage for the
summarizeToolResultformatting function is vastly improved, serving as a safety net against future regressions. All tests pass successfully under Vitest.PR created automatically by Jules for task 12827909540040504205 started by @toreleon