Skip to content

🧪 test: add test cases for seriesToBars#34

Draft
toreleon wants to merge 1 commit into
masterfrom
test-dnse-series-to-bars-13791705564865506920
Draft

🧪 test: add test cases for seriesToBars#34
toreleon wants to merge 1 commit into
masterfrom
test-dnse-series-to-bars-13791705564865506920

Conversation

@toreleon

Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed: Missing tests for seriesToBars in dnsePublic.
📊 Coverage: Covered happy paths (data mapped from arrays to object properties), missing close paths (skips data where close is null), and empty series path.
Result: Test coverage improved for data mapping functions in the public data sources code.


PR created automatically by Jules for task 13791705564865506920 started by @toreleon

Added tests for the `seriesToBars` function in `src/data/sources/dnsePublic.ts`
to improve testing coverage.

The tests ensure that the function correctly:
- Converts a full `OhlcvSeries` to a `Bar[]` array.
- Skips mapping intraday slots when the `close` price is missing (`null`).
- Returns an empty array when given an empty series.

Co-authored-by: toreleon <42534763+toreleon@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant