fix(client): hide client create from the user surface (installer-internal)#192
Open
LukasWodka wants to merge 1 commit into
Open
fix(client): hide client create from the user surface (installer-internal)#192LukasWodka wants to merge 1 commit into
client create from the user surface (installer-internal)#192LukasWodka wants to merge 1 commit into
Conversation
…ternal) `tracebloc client` offered users `create` — but provisioning is the installer's job (provision.sh calls `client create` with zero flags, cli#137), not a human command. Exposing it is inconsistent (its sibling `list` is already Hidden as "installer-internal, off the user-facing surface") and it's the front door to phantom-minting: a human running `tracebloc client create` STANDALONE mints a client the installer never deploys — an orphaned phantom (backend#970, the root of the cluster_conflict saga). Mark `create` Hidden, mirroring `list`. It stays fully callable — including `create --help`, so provision.sh's `_cli_supports_provisioning` probe is unaffected — but is no longer advertised. `tracebloc client` now shows only the user-useful `status`. Test: TestClientSubcommandVisibility pins create+list Hidden, status visible, and create still runnable (hidden != disabled). Full suite green; gofmt -s / errcheck / ineffassign / misspell clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracebloc clientoffered userscreatein its help — but provisioning is the installer's job (provision.shcallstracebloc client createwith zero flags, cli#137), not a human command. Exposing it is:listis alreadyHiddenwith the rationale "keep it callable, off the user-facing surface";createis more installer-internal, yet was visible. The curated top-leveltraceblochelp also omitscliententirely.tracebloc client createstandalone mints a client the installer never deploys: an orphaned "phantom" (the root of thecluster_conflictsaga; see backend#970 / #1021 / #1022).Change
Mark
createHidden, mirroringlist. It stays fully callable — includingclient create --help, soprovision.sh's_cli_supports_provisioningprobe is unaffected — it's just no longer advertised.tracebloc clientnow shows only the user-usefulstatus.(No behavior change to the command itself, exit codes, or the installer path — this is purely surface visibility.)
Tests
TestClientSubcommandVisibilitypinscreate+listHidden,statusvisible, andcreatestill runnable (hidden ≠ disabled). Fullgo test ./...green;gofmt -s/errcheck/ineffassign/misspellclean.Note
Low Risk
CLI help visibility only; no changes to provisioning logic, exit codes, or installer invocation paths.
Overview
Marks
tracebloc client createas hidden in Cobra, matching the already-hiddenlist, sotracebloc clienthelp surfaces onlystatusfor humans.createis unchanged functionally — the installer still runs it (including--helpfor capability probes); the goal is to stop advertising a command that, when run standalone, can mint a backend client the installer never deploys.Adds
TestClientSubcommandVisibilityto lock increate/listhidden,statusvisible, andcreatestill runnable.Reviewed by Cursor Bugbot for commit d05ece9. Bugbot is set up for automated code reviews on this repo. Configure here.