-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(deps): bump the github-actions group across 1 directory with 11 updates #4385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
|
|
||
| steps: | ||
| - name: ⬇️ Checkout repo | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
@@ -23,7 +23,7 @@ jobs: | |
| version: 10.33.2 | ||
|
|
||
| - name: ⎔ Setup node | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 setup-node bumped across a major version (v6 -> v7, ESM migration) This PR moves Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| with: | ||
| node-version: 24.18.0 | ||
| cache: "pnpm" | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -67,7 +67,7 @@ jobs: | |||||
| is_prerelease: ${{ steps.get_version.outputs.is_prerelease }} | ||||||
| steps: | ||||||
| - name: Checkout repo | ||||||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 # zizmor: ignore[artipacked] needs persisted git creds for tag push; no artifact upload here so no leak path | ||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.0 # zizmor: ignore[artipacked] needs persisted git creds for tag push; no artifact upload here so no leak path | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Version comment left stale after checkout action was upgraded The release checkout step's version label still reads v7.0.0 ( SHA/comment mismatch detailsThe commit
Suggested change
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||
| with: | ||||||
| fetch-depth: 0 | ||||||
| ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.ref || github.sha }} | ||||||
|
|
@@ -88,7 +88,7 @@ jobs: | |||||
| version: 10.33.2 | ||||||
|
|
||||||
| - name: Setup node | ||||||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||||||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| with: | ||||||
| node-version: 24.18.0 | ||||||
| cache: "pnpm" | ||||||
|
|
@@ -289,7 +289,7 @@ jobs: | |||||
| if: github.repository == 'triggerdotdev/trigger.dev' && github.event_name == 'workflow_dispatch' && github.event.inputs.type == 'prerelease' | ||||||
| steps: | ||||||
| - name: Checkout repo | ||||||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||||||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||||||
| with: | ||||||
| fetch-depth: 0 | ||||||
| ref: ${{ github.event.inputs.ref }} | ||||||
|
|
@@ -301,7 +301,7 @@ jobs: | |||||
| version: 10.33.2 | ||||||
|
|
||||||
| - name: Setup node | ||||||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||||||
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||||||
| with: | ||||||
| node-version: 24.18.0 | ||||||
| cache: "pnpm" | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Version comment left stale after checkout action was upgraded
The checkout step's version label still reads v7.0.0 (
# v7.0.0at.github/workflows/changesets-pr.yml:29) even though the pinned commit hash was advanced to the v7.0.1 release, so the human-readable label no longer matches the version that actually runs.Impact: Anyone auditing the workflow sees a version number that disagrees with the actual pinned action, which is misleading and can cause confusion during future upgrades.
SHA/comment mismatch details
The commit
3d3c42e5aac5ba805825da76410c181273ba90b1isactions/checkoutv7.0.1 — confirmed by every other workflow file in this PR (e.g..github/workflows/check-review-md.yml:30) which updated its comment to# v7.0.1. Only.github/workflows/changesets-pr.yml:29and.github/workflows/release.yml:70retained the old# v7.0.0label. The action behavior is correct (v7.0.1 runs); only the comment is stale.Was this helpful? React with 👍 or 👎 to provide feedback.