Skip to content

fix(webapp): stop logging full batch item contents in batchTriggerV3 - #4404

Open
carderne wants to merge 2 commits into
mainfrom
fix/batch-trigger-item-log-sec-405
Open

fix(webapp): stop logging full batch item contents in batchTriggerV3#4404
carderne wants to merge 2 commits into
mainfrom
fix/batch-trigger-item-log-sec-405

Conversation

@carderne

@carderne carderne commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

The idempotency grouping diagnostic now records task identifiers and item counts rather than full batch items. This keeps the log useful for troubleshooting without including payloads or options.

Performance notes

Should be better than baseline.

@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7a8a5c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The idempotency grouping step logged every batch item verbatim,
including its payload and options (which can carry arbitrary
customer metadata). Replace that with a summary of task identifiers
and item counts, and add a unit test covering the summary shape.
@carderne
carderne force-pushed the fix/batch-trigger-item-log-sec-405 branch from 7f5f033 to a978755 Compare July 28, 2026 08:54
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Added an exported helper that summarizes grouped batch items by task identifier and count. Updated debug logging to emit the summary instead of raw item payloads. Added tests covering populated inputs, sensitive-field exclusion, and empty input behavior.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description is missing required template sections such as Closes #, checklist, testing, changelog, and screenshots. Add the missing template sections, including an issue reference, checklist items, testing steps, changelog, and screenshots or note none.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: reducing batchTriggerV3 logs to exclude full item contents.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/batch-trigger-item-log-sec-405

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@carderne
carderne marked this pull request as ready for review July 28, 2026 09:59

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant