Skip to content

fix(webapp): restyle the leave and remove team member dialogs - #4411

Merged
samejr merged 2 commits into
mainfrom
samejr/remove-teammate-modal-refresh
Jul 28, 2026
Merged

fix(webapp): restyle the leave and remove team member dialogs#4411
samejr merged 2 commits into
mainfrom
samejr/remove-teammate-modal-refresh

Conversation

@samejr

@samejr samejr commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

The confirmation dialog for leaving a team or removing a teammate was still built on the old Alert primitive: the entire question sat in the title, there was no header divider or Esc affordance, and the footer used small buttons pinned to the right.

It now uses the standard Dialog layout the rest of the dashboard uses. The title is static ("Remove team member" / "Leave team"), the question moves into the body with the person's name and the organization highlighted, and the footer is a bordered row with medium Cancel and confirm buttons. A member who has not set a name is now identified by their email instead of "them".

Verified against a local dashboard on both dialogs. Confirming a removal posts the member id, deletes the membership and shows the success toast. Cancel, Esc, and Enter while Cancel is focused all close the dialog without issuing a request, leaving the member in place.

No release note needed: this is a visual restyle of an existing dialog with no behaviour change.

The dialog was still built on the old Alert primitive, so the whole
question sat in the title, there was no header divider or Esc
affordance, and the footer used small right-aligned buttons. It now
uses the standard Dialog layout, and the copy names the person being
removed instead of only saying "them".
@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7e02339

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Updated team settings confirmation modals from Alert-based layouts to Dialog components. Descriptions now accept JSX content, with styled organization and member identifiers in the leave and removal messages. The removal modal title was changed to “Remove team member,” and the change log was updated to describe the named teammate confirmation.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is on-topic but misses most required template sections and the issue-closing reference. Add the Closes #issue line and the missing Checklist, Testing, Changelog, and Screenshots sections from the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: restyling the leave/remove team member dialogs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/remove-teammate-modal-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

coderabbitai[bot]

This comment was marked as resolved.

@samejr

samejr commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

On the description check: this follows the ## Summary shape used by recent PRs in this repo rather than the contributor template. There is no changelog entry because the change is a visual restyle with no behaviour change, and the testing is described in the summary rather than as a checklist.

@samejr
samejr merged commit 1e14e29 into main Jul 28, 2026
39 checks passed
@samejr
samejr deleted the samejr/remove-teammate-modal-refresh branch July 28, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants