fix(webapp): restyle the leave and remove team member dialogs - #4411
Conversation
The dialog was still built on the old Alert primitive, so the whole question sat in the title, there was no header divider or Esc affordance, and the footer used small right-aligned buttons. It now uses the standard Dialog layout, and the copy names the person being removed instead of only saying "them".
|
WalkthroughUpdated team settings confirmation modals from Alert-based layouts to Dialog components. Descriptions now accept JSX content, with styled organization and member identifiers in the leave and removal messages. The removal modal title was changed to “Remove team member,” and the change log was updated to describe the named teammate confirmation. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
On the description check: this follows the |
Summary
The confirmation dialog for leaving a team or removing a teammate was still built on the old
Alertprimitive: the entire question sat in the title, there was no header divider orEscaffordance, and the footer used small buttons pinned to the right.It now uses the standard
Dialoglayout the rest of the dashboard uses. The title is static ("Remove team member" / "Leave team"), the question moves into the body with the person's name and the organization highlighted, and the footer is a bordered row with medium Cancel and confirm buttons. A member who has not set a name is now identified by their email instead of "them".Verified against a local dashboard on both dialogs. Confirming a removal posts the member id, deletes the membership and shows the success toast. Cancel,
Esc, and Enter while Cancel is focused all close the dialog without issuing a request, leaving the member in place.No release note needed: this is a visual restyle of an existing dialog with no behaviour change.