fix(tron): account for NATIVEVOTE gas and modifier diagnostics#127
Open
yanghang8612 wants to merge 1 commit into
Open
fix(tron): account for NATIVEVOTE gas and modifier diagnostics#127yanghang8612 wants to merge 1 commit into
yanghang8612 wants to merge 1 commit into
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
99f7e53 to
63453b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NATIVEVOTEmemory-array arguments as word arrays in gas estimation.msg.tokenidandmsg.tokenvalue).Root Cause
NATIVEVOTEreceives array lengths as element counts, but the gas estimator only charged the fixed vote cost and did not expand memory for the referenced array data. Separately, the nested modifier payable diagnostic still mentioned onlymsg.valueandcallvalue(), while the direct diagnostic had already been updated for TRON token fields.Validation
cmake -S . -B build -DCMAKE_BUILD_TYPE=Release -DUSE_Z3=OFF -DCMAKE_CXX_FLAGS='-Wno-deprecated-literal-operator'cmake --build build --target solc isoltest -j2build/test/tools/isoltest --no-semantic-tests -t 'syntaxTests/memberLookup/msg_value_modifier_view'build/solc/solc --bin --optimize -with a minimalvote(address[],uint256[])smoke contractLocal build note: Z3 was disabled because the installed version is newer than the pinned test version; the compiler warning flag suppresses an existing AppleClang warning in base code.