Add instance_type variable to aws-ec2 example (#794) - #797
Closed
thetelgote wants to merge 0 commit into
Closed
Conversation
Owner
|
Seems like your latest commit losted the content, I dont see related change in the PR, please double check @thetelgote |
thetelgote
force-pushed
the
fix/794-ec2-instance-type-variable
branch
from
July 27, 2026 11:41
686c858 to
69318c4
Compare
Contributor
Author
|
Confirmed — this was already merged via #795 (same fix, same author). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #794
What is the purpose of the change
The EC2 instance's
instance_typewas hardcoded tot2.microinmain.tf, whileami,region, andNamewere already exposed as variables. This adds aninstance_typevariable (default:t2.micro) tovariables.tfand referencesvar.instance_typeinmain.tf, keeping the example fully variable-driven and consistent with the rest of the file. No breaking change — default matches existing behavior.