Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion NEWS
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.6.0alpha2
?? ??? ????, PHP 8.6.0alpha3

- Reflection:
. Fixed bug GH-22681 (Reflection*::__toString() truncates on null bytes).
(DanielEScherzer)

16 Jul 2026, PHP 8.6.0alpha2

- Core:
. Sync Boost.Context assembly with 1.91.0. (kn1g78)
Expand Down
12 changes: 6 additions & 6 deletions ext/curl/interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ static size_t curl_write(char *data, size_t size, size_t nmemb, void *ctx)

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_write() called\n");
fprintf(stderr, "data = %s, size = %d, nmemb = %d, ctx = %x\n", data, size, nmemb, ctx);
fprintf(stderr, "data = %s, size = %zu, nmemb = %zu, ctx = %p\n", data, size, nmemb, (void *) ctx);
#endif

switch (write_handler->method) {
Expand Down Expand Up @@ -610,7 +610,7 @@ static int curl_progress(void *clientp, double dltotal, double dlnow, double ult

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_progress() called\n");
fprintf(stderr, "clientp = %x, dltotal = %f, dlnow = %f, ultotal = %f, ulnow = %f\n", clientp, dltotal, dlnow, ultotal, ulnow);
fprintf(stderr, "clientp = %p, dltotal = %f, dlnow = %f, ultotal = %f, ulnow = %f\n", clientp, dltotal, dlnow, ultotal, ulnow);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.progress)) {
return rval;
Expand Down Expand Up @@ -651,7 +651,7 @@ static int curl_xferinfo(void *clientp, curl_off_t dltotal, curl_off_t dlnow, cu

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_xferinfo() called\n");
fprintf(stderr, "clientp = %x, dltotal = %ld, dlnow = %ld, ultotal = %ld, ulnow = %ld\n", clientp, dltotal, dlnow, ultotal, ulnow);
fprintf(stderr, "clientp = %p, dltotal = %ld, dlnow = %ld, ultotal = %ld, ulnow = %ld\n", clientp, dltotal, dlnow, ultotal, ulnow);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.xferinfo)) {
return rval;
Expand Down Expand Up @@ -746,7 +746,7 @@ static int curl_ssh_hostkeyfunction(void *clientp, int keytype, const char *key,

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_ssh_hostkeyfunction() called\n");
fprintf(stderr, "clientp = %x, keytype = %d, key = %s, keylen = %zu\n", clientp, keytype, key, keylen);
fprintf(stderr, "clientp = %p, keytype = %d, key = %s, keylen = %zu\n", clientp, keytype, key, keylen);
#endif

zval args[4];
Expand Down Expand Up @@ -843,7 +843,7 @@ static int curl_seek(void *clientp, curl_off_t offset, int origin)

#if PHP_CURL_DEBUG
fprintf(stderr, "curl_seek() called\n");
fprintf(stderr, "clientp = %x, offset = %ld, origin = %d\n", clientp, offset, origin);
fprintf(stderr, "clientp = %p, offset = %ld, origin = %d\n", clientp, offset, origin);
#endif
if (!ZEND_FCC_INITIALIZED(ch->handlers.seek)) {
return rval;
Expand Down Expand Up @@ -2801,7 +2801,7 @@ static void curl_free_obj(zend_object *object)
php_curl *ch = curl_from_obj(object);

#if PHP_CURL_DEBUG
fprintf(stderr, "DTOR CALLED, ch = %x\n", ch);
fprintf(stderr, "DTOR CALLED, ch = %p\n", (void *) ch);
#endif

if (!ch->cp) {
Expand Down
8 changes: 6 additions & 2 deletions ext/reflection/php_reflection.c
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,9 @@ static void _enum_case_string(smart_str *str, const zend_string *name, zend_clas
}

if (c->doc_comment) {
smart_str_append_printf(str, "%s%s\n", indent, ZSTR_VAL(c->doc_comment));
smart_str_appends(str, indent);
smart_str_append(str, c->doc_comment);
smart_str_appendc(str, '\n');
}
smart_str_append_printf(str, "%sCase %s", indent, ZSTR_VAL(name));
if (c->ce->enum_backing_type == IS_UNDEF) {
Expand All @@ -683,7 +685,9 @@ static void _enum_case_string(smart_str *str, const zend_string *name, zend_clas
zval *enum_val = zend_enum_fetch_case_value(Z_OBJ(c->value));
zend_string *tmp_value_str;
zend_string *value_str = zval_get_tmp_string(enum_val, &tmp_value_str);
smart_str_append_printf(str, " = %s\n", ZSTR_VAL(value_str));
smart_str_appends(str, " = ");
smart_str_append(str, value_str);
smart_str_appendc(str, '\n');
zend_tmp_string_release(tmp_value_str);
}
}
Expand Down
61 changes: 61 additions & 0 deletions ext/reflection/tests/gh22681/ReflectionEnum_backed_value.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
--TEST--
GH-22681: null bytes in backed value truncate ReflectionEnum::__toString()
--FILE--
<?php

enum Demo: string {
case DEMO = "F\0oo";
}

$r = new ReflectionEnum(Demo::class);
echo $r;
var_dump( new ReflectionEnumBackedCase(Demo::class, 'DEMO')->getBackingValue() );
?>
--EXPECTF--
Enum [ <user> enum Demo: string implements UnitEnum, BackedEnum ] {
@@ %s %d-%d

- Enum cases [1] {
Case DEMO = F%0oo
}

- Constants [0] {
}

- Static properties [0] {
}

- Static methods [3] {
Method [ <internal, prototype UnitEnum> static public method cases ] {

- Parameters [0] {
}
- Return [ array ]
}

Method [ <internal, prototype BackedEnum> static public method from ] {

- Parameters [1] {
Parameter #0 [ <required> string|int $value ]
}
- Return [ static ]
}

Method [ <internal, prototype BackedEnum> static public method tryFrom ] {

- Parameters [1] {
Parameter #0 [ <required> string|int $value ]
}
- Return [ ?static ]
}
}

- Properties [2] {
Property [ public protected(set) readonly string $name ]
Property [ public protected(set) readonly string $value ]
}

- Methods [0] {
}
}
string(4) "F%0oo"
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Enum [ <user> enum Demo implements UnitEnum ] {
@@ %s(%d) : eval()'d code %d-%d

- Enum cases [1] {
/** F
/** F%0oo */
Case C
}

Expand Down