Implement supercon enum pf#4374
Open
chris-ashe wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
=======================================
Coverage 48.79% 48.80%
=======================================
Files 151 151
Lines 29408 29348 -60
=======================================
- Hits 14351 14323 -28
+ Misses 15057 15025 -32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
requested changes
Jun 30, 2026
clmould
left a comment
Collaborator
There was a problem hiding this comment.
Just a few tiny things but happy otherwise!
| # ITER Nb3Sn critical surface parameterization | ||
| bc20m = 32.97e0 | ||
| tc0m = 16.06e0 | ||
| bc20m = 32.97e0 # [T] critical field at 0 K and 0 strain |
Collaborator
There was a problem hiding this comment.
Do the other instances like this need this longer, more descriptive comment?
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
a0a2f4e to
92b9cea
Compare
92b9cea to
c786e71
Compare
clmould
reviewed
Jun 30, 2026
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: