Skip to content

Implement supercon enum pf#4374

Open
chris-ashe wants to merge 6 commits into
mainfrom
implement_supercon_enum_pf
Open

Implement supercon enum pf#4374
chris-ashe wants to merge 6 commits into
mainfrom
implement_supercon_enum_pf

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.80%. Comparing base (a285d2b) to head (94a2af9).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
process/models/pfcoil.py 51.85% 13 Missing ⚠️
process/models/tfcoil/superconducting.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4374   +/-   ##
=======================================
  Coverage   48.79%   48.80%           
=======================================
  Files         151      151           
  Lines       29408    29348   -60     
=======================================
- Hits        14351    14323   -28     
+ Misses      15057    15025   -32     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould self-assigned this Jun 24, 2026

@clmould clmould left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tiny things but happy otherwise!

Comment thread process/models/pfcoil.py Outdated
Comment thread process/models/pfcoil.py Outdated
Comment thread process/models/pfcoil.py Outdated
Comment thread process/models/pfcoil.py
# ITER Nb3Sn critical surface parameterization
bc20m = 32.97e0
tc0m = 16.06e0
bc20m = 32.97e0 # [T] critical field at 0 K and 0 strain

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other instances like this need this longer, more descriptive comment?

Comment thread process/models/pfcoil.py Outdated
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
@chris-ashe chris-ashe requested a review from clmould June 30, 2026 10:29
@chris-ashe chris-ashe force-pushed the implement_supercon_enum_pf branch from a0a2f4e to 92b9cea Compare June 30, 2026 10:46
@chris-ashe chris-ashe force-pushed the implement_supercon_enum_pf branch from 92b9cea to c786e71 Compare June 30, 2026 10:48
Comment thread process/models/pfcoil.py Outdated
Co-authored-by: clmould <86794332+clmould@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants