Correct hstar being stored on data structure#4396
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4396 +/- ##
==========================================
- Coverage 48.84% 48.80% -0.04%
==========================================
Files 151 151
Lines 29377 29348 -29
==========================================
- Hits 14348 14323 -25
+ Misses 15029 15025 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
left a comment
There was a problem hiding this comment.
Just really needs a way to be able to take the loss power terms from whatever equation is being used as the value is hardcoded for a single scaling at the moment
| @@ -1049,7 +1055,7 @@ def calculate_confinement_time( | |||
| ** 0.31 | |||
There was a problem hiding this comment.
This will only work for the selected scaling if the loss power index is (1-0.31), so really just the IPB98 scalings in this case
There was a problem hiding this comment.
This will need to be turned into an issue. This PR is just stopping hstar being incorrectly set every time calculate_confinement_time is called
I think
hstaris being incorrectly set on the data structure incalculate_confinement_time.calculate_confinement_timeis also called when creating the H-factor table for the OUT.DAT. I believe that thehstarfrom this is what was being written to the MFILE, not thehstarfrom the selected confinement scaling.