Skip to content

Create confinement time dataclass#4398

Open
chris-ashe wants to merge 5 commits into
mainfrom
create_confinement_time_dataclass
Open

Create confinement time dataclass#4398
chris-ashe wants to merge 5 commits into
mainfrom
create_confinement_time_dataclass

Conversation

@chris-ashe

Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@chris-ashe chris-ashe requested a review from a team as a code owner June 29, 2026 23:07
@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.81%. Comparing base (bcd37bc) to head (cc466ee).

Files with missing lines Patch % Lines
process/models/physics/physics.py 0.00% 7 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 7 Missing ⚠️
process/models/physics/confinement_time.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4398   +/-   ##
=======================================
  Coverage   48.80%   48.81%           
=======================================
  Files         151      151           
  Lines       29348    29375   +27     
=======================================
+ Hits        14323    14338   +15     
- Misses      15025    15037   +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe added the Physics Relating to the physics models label Jun 30, 2026
@chris-ashe chris-ashe force-pushed the create_confinement_time_dataclass branch 2 times, most recently from 6e18e5c to bda550b Compare June 30, 2026 00:04
@chris-ashe chris-ashe requested a review from clmould June 30, 2026 09:18
@clmould clmould self-assigned this Jun 30, 2026
@chris-ashe chris-ashe force-pushed the create_confinement_time_dataclass branch from bda550b to a594f85 Compare June 30, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Physics Relating to the physics models Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants