Add GVL/allocation instrumentation and optional log fields#58
Open
Peralphix wants to merge 4 commits into
Open
Add GVL/allocation instrumentation and optional log fields#58Peralphix wants to merge 4 commits into
Peralphix wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted GVL/memory instrumentation from our applications into the shared gem.
Added new files (loaded only via explicit
require):patches/active_support_event— adds#gvl_timeand#malloc_increase_bytestoActiveSupport::Notifications::Event;patches/rails_semantic_logger— enriches the "Completed" action log entry with GC/GVL/allocation stats;semantic_logger/sidekiq_job_metrics— same stats for Sidekiq jobs.TinyJsonFormatternow supports optionaldurationandpayloadkeys incustom_names_mapping. Previously such keys were silently ignored. Output is unchanged unless the keys are explicitly requested.