Skip to content

Gives oncoanalyser roles access to read/write to cohort projects#118

Open
alexiswl wants to merge 1 commit into
mainfrom
allow-oncoanalyser-access-to-cohort-projects
Open

Gives oncoanalyser roles access to read/write to cohort projects#118
alexiswl wants to merge 1 commit into
mainfrom
allow-oncoanalyser-access-to-cohort-projects

Conversation

@alexiswl

@alexiswl alexiswl commented Feb 2, 2025

Copy link
Copy Markdown
Member

No description provided.

@alexiswl alexiswl self-assigned this Feb 2, 2025

@scwatts scwatts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There already is a wildcard for prefixes used in bucket action grants so may not need these here. See:

orcabusDataBucket.grantReadWrite(role, `${props.orcabusDataS3PrefixTemp}*`);
orcabusDataBucket.grantDelete(role, `${props.orcabusDataS3PrefixTemp}*`);
orcabusDataBucket.grantReadWrite(role, `${props.orcabusDataS3PrefixOutput}*`);
orcabusDataBucket.grantRead(role, `${props.orcabusDataS3ByobPrefix}*`)

@reisingerf reisingerf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for now, but we should sort this out properly...

@alexiswl

alexiswl commented Feb 3, 2025

Copy link
Copy Markdown
Member Author

There already is a wildcard for prefixes used in bucket action grants so may not need these here. See:

Run failed immediately with permission errors without setting the asterisk after byob-icav2/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants