Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ceb31ec
chore(generator): migrate to std::optional (#16230)
colinmoy Jul 15, 2026
40d3ab0
doc(generator): add first iteration of ARCHITECTURE.md (#16263)
scotthart Jul 15, 2026
62c6d2d
fix(storage): prevent indefinite hang when calling Close() on async a…
kalragauri Jul 16, 2026
0df223a
chore(deps): update github/codeql-action digest to 99df26d (#16247)
renovate-bot Jul 16, 2026
d7fe6af
impl(bigtable): disable unrelated log messages in TableApplyWithLoggi…
scotthart Jul 16, 2026
f929d3a
chore(deps): update github/codeql-action digest to 7188fc3 (#16265)
renovate-bot Jul 16, 2026
2784301
chore(deps): update googletest to v1.17.0 (#16197) (#16231)
colinmoy Jul 16, 2026
192a56c
chore(storage): migrate to std::optional (#16229)
colinmoy Jul 16, 2026
073df34
chore(deps): update dependency google_cloud_cpp to v3.7.0 (#16267)
renovate-bot Jul 16, 2026
6fd3745
feat(storage): introduce unified checksum options and deprecate old o…
v-pratap Jul 17, 2026
2ea6ec7
feat(storage): migrate async client to unified checksum options
v-pratap Jul 15, 2026
a5ea188
fix(storage): address reviewer comments and fix format
v-pratap Jul 15, 2026
2473a8c
fix: resolve review comments and unit tests failures
v-pratap Jul 15, 2026
5228545
fix(storage): clang-format style issues in connection_impl.cc
v-pratap Jul 15, 2026
1424528
fix: address PR review comments for read hash tests and upload checks…
v-pratap Jul 15, 2026
b76b819
fix(storage): resolve read hash tests failing due to incorrect checks…
v-pratap Jul 15, 2026
39c4a25
fix(storage): resolve clang-format style issues
v-pratap Jul 16, 2026
c0cf77b
fix(storage): resolve reviewer comments for read hash tests and uploa…
v-pratap Jul 17, 2026
23bb221
fix(storage): resolve clang format
v-pratap Jul 17, 2026
e6d1487
fix(storage): add missing TODO username and disable deprecation warni…
v-pratap Jul 17, 2026
e2c354a
fix(storage): fix alphabetical order in google_cloud_cpp_storage_grpc…
v-pratap Jul 17, 2026
d26d929
impl(rest): use PQC algorithm when available (#16253)
scotthart Jul 17, 2026
228b083
test(storage): retain legacy checksum option test cases
v-pratap Jul 20, 2026
c419f36
Merge branch 'main' into unified-checksum-options-pr2
v-pratap Jul 20, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 3 additions & 1 deletion .bazelignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
build-out/
ci/
ci/bzlmod_tests/consumer-test
ci/verify_current_targets
ci/verify_deprecated_targets
cmake-out/
cmake-build-debug/
cmake-build-coverage/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
--clean-after-build

- name: Initialize CodeQL
uses: github/codeql-action/init@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4
uses: github/codeql-action/init@7188fc363630916deb702c7fdcf4e481b751f97a # v4
with:
languages: ${{ matrix.language }}

Expand All @@ -92,4 +92,4 @@ jobs:
cmake --build build/output

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4
uses: github/codeql-action/analyze@7188fc363630916deb702c7fdcf4e481b751f97a # v4
2 changes: 1 addition & 1 deletion ci/bzlmod_tests/consumer-test/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module(name = "bzlmod-consumer-test")

bazel_dep(name = "google_cloud_cpp", version = "3.6.0")
bazel_dep(name = "google_cloud_cpp", version = "3.7.0")
bazel_dep(name = "googletest", version = "1.15.2")
bazel_dep(name = "rules_cc", version = "0.1.1")
99 changes: 99 additions & 0 deletions ci/cloudbuild/builds/showcase.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
#!/bin/bash
#
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -euo pipefail

source "$(dirname "$0")/../../lib/init.sh"
source module ci/cloudbuild/builds/lib/bazel.sh
source module ci/cloudbuild/builds/lib/cloudcxxrc.sh
source module ci/lib/io.sh

export CC=clang
export CXX=clang++

mapfile -t args < <(bazel::common_args)

io::log_h1 "Running Showcase PQC tests with Bazel"

# Ensure server and temporary files are cleaned up on script exit
cleanup() {
rm -f ci/showcase/BUILD.bazel
if [[ -n "${showcase_pid:-}" ]]; then
kill "${showcase_pid}" || true
fi
}
trap cleanup EXIT

SHOWCASE_VERSION="${SHOWCASE_VERSION:-main}"
SHOWCASE_DIR="ci/showcase/googleapis/gapic-showcase"
if [[ ! -f "${SHOWCASE_DIR}/go.mod" ]]; then
io::log_h2 "Downloading googleapis/gapic-showcase (${SHOWCASE_VERSION}) tarball into ${SHOWCASE_DIR}"
mkdir -p "${SHOWCASE_DIR}"
curl -fsSL "https://github.com/googleapis/gapic-showcase/archive/${SHOWCASE_VERSION}.tar.gz" |
tar -C "${SHOWCASE_DIR}" -xzf - --strip-components=1
fi

# Copy BUILD.bazel.in to BUILD.bazel. These shenanigans are necessary because
# we want to test with packages that do not have public visibility and creating
# a persistent BUILD.bazel file leads to errors when the files it refers to
# are not there.
cp ci/showcase/BUILD.bazel.in ci/showcase/BUILD.bazel

bazel_output_base="$(bazel info output_base)"
protobuf_proto_path="${bazel_output_base}/external/protobuf+/src"
googleapis_proto_path="${bazel_output_base}/external/googleapis+"

io::log_h2 "Running C++ codegen generator for gapic-showcase echo.proto"
bazel run --action_env=GOOGLE_CLOUD_CPP_ENABLE_CLOG=yes \
//generator:google-cloud-cpp-codegen -- \
--protobuf_proto_path="${protobuf_proto_path}" \
--googleapis_proto_path="${googleapis_proto_path}" \
--golden_proto_path="${PROJECT_ROOT}/${SHOWCASE_DIR}/schema" \
--output_path="${PROJECT_ROOT}/ci/showcase" \
--check_comment_substitutions=false \
--config_file="${PROJECT_ROOT}/ci/showcase/showcase_config.textproto"

io::log_h2 "Building gapic-showcase server binary"
mkdir -p "${PROJECT_ROOT}/ci/showcase/bin"
(
cd "${PROJECT_ROOT}/${SHOWCASE_DIR}"
go build -o "${PROJECT_ROOT}/ci/showcase/bin/gapic-showcase" ./cmd/gapic-showcase
)

SHOWCASE_PORT="${SHOWCASE_PORT:-7469}"
SHOWCASE_CA_CERT="${PROJECT_ROOT}/ci/showcase/showcase.pem"
rm -f "${SHOWCASE_CA_CERT}"

io::log_h2 "Starting gapic-showcase server on port ${SHOWCASE_PORT} with TLS"
"${PROJECT_ROOT}/ci/showcase/bin/gapic-showcase" run \
--port=":${SHOWCASE_PORT}" \
--tls \
--ca-cert-output-file="${SHOWCASE_CA_CERT}" >/dev/null 2>&1 &
showcase_pid=$!

# Wait up to 15 seconds for CA cert file to be created and server to be listening
for _ in $(seq 1 30); do
if [[ -r "${SHOWCASE_CA_CERT}" ]] && curl --insecure -s "https://localhost:${SHOWCASE_PORT}" >/dev/null 2>&1; then
break
fi
sleep 0.5
done

io::log_h2 "Running showcase tests"
bazel test --test_env=SHOWCASE_PORT="${SHOWCASE_PORT}" \
--test_env=SHOWCASE_CA_CERT="${SHOWCASE_CA_CERT}" \
--test_output=errors \
//ci/showcase:rest_pqc_test
28 changes: 28 additions & 0 deletions ci/cloudbuild/triggers/showcase-ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

filename: ci/cloudbuild/cloudbuild.yaml
github:
name: google-cloud-cpp
owner: googleapis
push:
branch: main
includeBuildLogs: INCLUDE_BUILD_LOGS_WITH_STATUS
name: showcase-ci
substitutions:
_BUILD_NAME: showcase
_DISTRO: fedora-latest-bazel
_TRIGGER_TYPE: ci
tags:
- ci
29 changes: 29 additions & 0 deletions ci/cloudbuild/triggers/showcase-pr.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

filename: ci/cloudbuild/cloudbuild.yaml
github:
name: google-cloud-cpp
owner: googleapis
pullRequest:
branch: main
commentControl: COMMENTS_ENABLED_FOR_EXTERNAL_CONTRIBUTORS_ONLY
includeBuildLogs: INCLUDE_BUILD_LOGS_WITH_STATUS
name: showcase-pr
substitutions:
_BUILD_NAME: showcase
_DISTRO: fedora-latest-bazel
_TRIGGER_TYPE: pr
tags:
- pr
1 change: 1 addition & 0 deletions ci/showcase/.bazelignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bazel-*
33 changes: 33 additions & 0 deletions ci/showcase/.bazelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Copyright 2022 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Use host-OS-specific config lines from bazelrc files.
build --enable_platform_specific_config=true

# The project requires C++ >= 17.
build:linux --cxxopt=-std=c++17
build:macos --cxxopt=-std=c++17
# Protobuf and gRPC require C++17 to compile the "host"
# targets, such as protoc and the grpc plugin.
build:linux --host_cxxopt=-std=c++17
build:macos --host_cxxopt=-std=c++17

# Do not create the convenience links. They are inconvenient when the build
# runs inside a docker image or if one builds a quickstart and then builds
# the project separately.
build --experimental_convenience_symlinks=ignore

# TODO(#13311) - remove once gRPC works with Bazel v7 or when gRPC stops using
# `apple_rules`.
common:macos --repo_env=BAZEL_NO_APPLE_CPP_TOOLCHAIN=1
1 change: 1 addition & 0 deletions ci/showcase/.bazelversion
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
8.7.0
7 changes: 7 additions & 0 deletions ci/showcase/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Ignore downloaded gapic-showcase tarball contents when running locally.
googleapis/gapic-showcase/
# Ignore dynamically generated C++ library files when running locally.
google/showcase/
# Ignore compiled binaries and certificates when running locally.
bin/
showcase.pem
113 changes: 113 additions & 0 deletions ci/showcase/BUILD.bazel.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

load("@com_google_protobuf//bazel:cc_proto_library.bzl", "cc_proto_library")
load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
load("@grpc//bazel:cc_grpc_library.bzl", "cc_grpc_library")

package(default_visibility = ["//visibility:private"])

licenses(["notice"])

proto_library(
name = "showcase_echo_proto",
srcs = ["googleapis/gapic-showcase/schema/google/showcase/v1beta1/echo.proto"],
strip_import_prefix = "googleapis/gapic-showcase/schema",
deps = [
"@com_google_protobuf//:any_proto",
"@com_google_protobuf//:duration_proto",
"@com_google_protobuf//:timestamp_proto",
"@googleapis//google/api:annotations_proto",
"@googleapis//google/api:client_proto",
"@googleapis//google/api:field_behavior_proto",
"@googleapis//google/api:field_info_proto",
"@googleapis//google/api:routing_proto",
"@googleapis//google/longrunning:operations_proto",
"@googleapis//google/rpc:status_proto",
],
)

cc_proto_library(
name = "showcase_echo_cc_proto",
deps = [":showcase_echo_proto"],
)

cc_grpc_library(
name = "showcase_echo_cc_grpc",
srcs = [":showcase_echo_proto"],
grpc_only = True,
deps = [":showcase_echo_cc_proto"],
)

filegroup(
name = "echo_srcs",
srcs = glob([
"google/showcase/v1beta1/internal/*_sources.cc",
]),
)

filegroup(
name = "echo_hdrs",
srcs = glob(
include = [
"google/showcase/v1beta1/*.cc",
"google/showcase/v1beta1/*.h",
"google/showcase/v1beta1/internal/*.cc",
"google/showcase/v1beta1/internal/*.h",
],
exclude = [
"google/showcase/v1beta1/internal/*_sources.cc",
],
),
)

cc_library(
name = "showcase_echo_client",
srcs = [":echo_srcs"],
hdrs = [":echo_hdrs"],
copts = [
"-Ici/showcase",
"-I$(BINDIR)/ci/showcase",
],
includes = ["."],
strip_include_prefix = "",
deps = [
":showcase_echo_cc_grpc",
":showcase_echo_cc_proto",
"//:common",
"//:grpc_utils",
"//google/cloud:google_cloud_cpp_rest_internal",
"//google/cloud:google_cloud_cpp_rest_protobuf_internal",
"@abseil-cpp//absl/strings",
"@googleapis//google/longrunning:longrunning_cc_grpc",
],
)

cc_test(
name = "rest_pqc_test",
srcs = ["rest_pqc_test.cc"],
copts = [
"-Ici/showcase",
"-I$(BINDIR)/ci/showcase",
],
tags = ["integration-test"],
deps = [
":showcase_echo_client",
"//:common",
"//google/cloud:google_cloud_cpp_rest_internal",
"//google/cloud/testing_util:google_cloud_cpp_testing_private",
"//google/cloud/testing_util:google_cloud_cpp_testing_rest_private",
"@googletest//:gtest_main",
],
)
Loading
Loading