Skip to content

feat(azure_blob): make storage API version configurable - #25952

Draft
opencow wants to merge 2 commits into
vectordotdev:masterfrom
opencow:codex/azure-blob-api-version
Draft

feat(azure_blob): make storage API version configurable#25952
opencow wants to merge 2 commits into
vectordotdev:masterfrom
opencow:codex/azure-blob-api-version

Conversation

@opencow

@opencow opencow commented Jul 27, 2026

Copy link
Copy Markdown

Summary

Vector configuration

How did you test this PR?

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@opencow
opencow requested a review from a team as a code owner July 27, 2026 20:29
@github-actions github-actions Bot added the domain: sinks Anything related to the Vector's sinks label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Before we can merge this PR, please sign our Contributor License Agreement.

To sign, copy and post the phrase below as a new comment on this PR.

Note: If the bot says your username was not found, the email used in your git commit may not be linked to your GitHub account. Fix this at github.com/settings/emails, then comment recheck to retry.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@datadog-vectordotdev

datadog-vectordotdev Bot commented Jul 27, 2026

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

🚦 1 Pipeline job failed

CLA Assistant | CLAAssistant   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 231e27c | Docs | Datadog PR Page | Give us feedback!

@opencow
opencow marked this pull request as draft July 27, 2026 20:31

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d0183f593

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

/// services that do not support the SDK's default version. The configured version must support
/// every operation and option used by this sink.
#[configurable(metadata(docs::examples = "2021-08-06"))]
pub api_version: Option<String>,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate the Azure Blob component reference

Add the generated documentation entry for api_version to website/cue/reference/components/sinks/generated/azure_blob.cue; without it, the public Azure Blob configuration reference omits this new user-facing option and make check-generated-docs will report the generated docs as stale.

AGENTS.md reference: AGENTS.md:L206-L212

Useful? React with 👍 / 👎.

Comment thread src/sinks/azure_blob/config.rs Outdated
Comment on lines +679 to +682
NaiveDate::parse_from_str(api_version, "%Y-%m-%d").map_err(|_| {
format!("Invalid Azure Blob Storage API version `{api_version}`; expected YYYY-MM-DD")
})?;
options.version = api_version.to_owned();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enforce the exact API-version wire format

Reject non-canonical inputs such as 2021-8-6: Chrono's numeric date directives accept unpadded components, but the original string is then copied unchanged into x-ms-version. In that case the sink builds successfully and only fails later when Azure rejects the unsupported header during the healthcheck or uploads, despite the validation error promising an exact YYYY-MM-DD format.

Useful? React with 👍 / 👎.

@github-actions github-actions Bot added docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant