docs(elasticsearch sink): fix invalid version field example - #25957
Open
ypid-work wants to merge 1 commit into
Open
docs(elasticsearch sink): fix invalid version field example#25957ypid-work wants to merge 1 commit into
ypid-work wants to merge 1 commit into
Conversation
The given example is bad because it is invalid for Elasticsearch due to: > It must be a non-negative long number. Ref: https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-create#operation-create-version Better use two examples to show the features of the templating. Introduced in: https://github.com/vectordotdev/vector/pull/20102/changes#diff-4ddfc8ed62933b9dda997c8f490bfe56e87de0f809eaf318f5f690e2d27e9a57R265 Introduced in: 8a20f05
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
github-actions
Bot
added
domain: sinks
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
pront
enabled auto-merge
July 28, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The given example is bad because it is invalid for Elasticsearch due to:
Ref: https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-create#operation-create-version
Better use two examples to show the features of the templating.
Vector configuration
How did you test this PR?
illegal_argument_exception./scripts/cue.sh fmtIs this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
More specifically: https://github.com/vectordotdev/vector/pull/20102/changes#diff-4ddfc8ed62933b9dda997c8f490bfe56e87de0f809eaf318f5f690e2d27e9a57R265