Support framework base paths outside Next.js#2771
Draft
NathanColosimo wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 61407e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (739 failed)express (120 failed):
hono (120 failed):
nitro (120 failed):
nuxt (120 failed):
sveltekit (139 failed):
vite (120 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| // Insert workflow routes right after | ||
| config.routes.splice(insertIndex + 1, 0, ...WORKFLOW_ROUTES); | ||
| config.routes.splice( |
Contributor
There was a problem hiding this comment.
On a Vercel Astro deploy with a framework base path set, the workflow flow/webhook endpoints stay reachable at the un-prefixed ROOT path (returning 200) because the base-path protection applied in the local build is never enforced on the Vercel build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #2732.
Adds non-Next base path support using framework-native config only. There is no
WORKFLOW_BASE_PATHenv var and no new user-facing Workflow option.srcpatterns while keeping function/static destinations internal.kit.paths.base, passes it through the builder, preserves generated health method aliases after adapter processing, and lets SvelteKit mount static manifest assets under the configured base.config.base, prefixes Vercel route regexes, and guards generated handlers so the root workflow endpoints do not succeed when a base path is configured.baseURLor Nuxt-styleapp.baseURL, passes it into Workflow URL generation and legacy BOA output, and keeps Nitro internal routes/function rules unprefixed because Nitro appliesbaseURLwhen serving and generating Vercel output.app.baseURLinto Nitro when Nitro has not already configuredbaseURL.WORKFLOW_E2E_BASE_PATH=/appacross SvelteKit, Astro, Nitro v2/v3, Nuxt, Vite, TanStack Start, Express, Fastify, and Hono.How did you test your changes?
PATH=/Users/nathancolosimo/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:/Users/nathancolosimo/.cache/codex-runtimes/codex-primary-runtime/dependencies/bin:$PATH HUSKY=0 pnpm dlx pnpm@10.20.0 --filter @workflow/builders... --filter @workflow/nitro... --filter @workflow/nuxt --filter @workflow/sveltekit... --filter @workflow/astro... buildWORKFLOW_E2E_BASE_PATH=/app WORKFLOW_PUBLIC_MANIFEST=1 ... buildfor SvelteKit, Astro, Nitro v2, Nitro v3, Nuxt, Vite, and TanStack Start workbenches.biome checkover touched files passed with warnings only.pnpm dlx pnpm@10.20.0 changeset status --since=origin/nathanc/fix-next-base-pathpassed.Ad-hoc Vercel preview deployment was not run from this machine because the Vercel CLI and required auth/OIDC environment variables were not available. The PR is draft so CI and preview deployments can validate the Vercel side.
PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRgit commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is complete