fix(ui): prevent theme flash and delayed dark mode application#439
Open
SaKaNa-Y wants to merge 1 commit into
Open
fix(ui): prevent theme flash and delayed dark mode application#439SaKaNa-Y wants to merge 1 commit into
SaKaNa-Y wants to merge 1 commit into
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When opening Oxc / Vite / Rolldown for the first time, the UI briefly appears in the light theme and then switches to dark mode. Oxc has a more noticeable issue where it only switches back to dark mode after scrolling.
The main problem is that the theme is not applied before the initial render. I tried making some changes to fix this.
Linked Issues
Additional context