refactor(cli): drop comments restating adjacent dns/subdomain code#330
refactor(cli): drop comments restating adjacent dns/subdomain code#330TBX3D wants to merge 1 commit into
Conversation
pr summary1 files changed (+1 -2)
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
=======================================
Coverage ? 64.87%
=======================================
Files ? 88
Lines ? 7858
Branches ? 0
=======================================
Hits ? 5098
Misses ? 2367
Partials ? 393 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
73221e0 to
d5e235c
Compare
vmfunc
left a comment
There was a problem hiding this comment.
clean extraction. the only spot that isn't mechanical is the apimode marshal-failure path, and you got it right: return targetScan{scansRun: scansRun, logFiles: logFiles}, nil keeps the scan labels and log files but drops findings/report, same as the old continue. logFiles moving to a local and merging back in Run still lands in app.logFiles before PrintSummary, so the summary is unchanged, and nothing reads app.logFiles mid-scan so the timing shift is invisible.
TestScanTargetIsolatesPerTargetState is the right test for the seam. two sequential targets each reporting a single scan is exactly what a shared slice would break.
conflicts with main though, rebase and it's in.
8b0c53d to
a350757
Compare
|
rebased, and there is almost nothing left. #367 landed that means your approval no longer covers what is here, so please re-read before merging, or close it if a two-comment cleanup is not worth the churn. either is fine by me. |
two comments in scanTarget restate the line they sit above:
dnsResults = result // Store the DNS results, and a// Only run subdomain takeover check if DNS scan is enabledabove theif app.settings.SubdomainTakeoverit describes. drop both.this PR previously carried the scanTarget/targetScan extraction as well. that landed on main in #367 with the same signature and the same
sif_scantarget_test.go, so only the comment trim is left here.