-
Notifications
You must be signed in to change notification settings - Fork 220
docs: fix overrides behavior mismatch
#1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liangmiQwQ
wants to merge
12
commits into
voidzero-dev:main
Choose a base branch
from
liangmiQwQ:docs/fix-override-semantic-mismatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8b0bd6a
docs: fix `overrides` behavior mismatch
liangmiQwQ f8e7e8e
Merge branch 'main' into docs/fix-override-semantic-mismatch
liangmiQwQ 8c313f1
wip
liangmiQwQ 16e1cdf
snap tests
liangmiQwQ affcdb7
rename
liangmiQwQ 0cdb72f
rename
liangmiQwQ ac73519
change
liangmiQwQ 449e823
change
liangmiQwQ 7c94a10
Merge branch 'main' into docs/fix-override-semantic-mismatch
liangmiQwQ fb33874
Merge branch 'main' into docs/fix-override-semantic-mismatch
liangmiQwQ 74799a9
Merge branch 'main' into docs/fix-override-semantic-mismatch
liangmiQwQ 2bf7760
Merge branch 'main' into docs/fix-override-semantic-mismatch
liangmiQwQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "name": "lint-override-semantic", | ||
| "version": "1.0.0", | ||
| "private": true, | ||
| "type": "module" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| [1]> vp lint src # extends rules are preserved when a file override adds Vue rules | ||
|
|
||
| × eslint(no-console): Unexpected console statement. | ||
| ╭─[src/example.js:1:1] | ||
| 1 │ console.log(); | ||
| · ─────────── | ||
| ╰──── | ||
| help: Delete this console statement. | ||
|
|
||
| × vue(no-export-in-script-setup): <script setup>` cannot contain ES module exports. | ||
| ╭─[src/example.vue:8:16] | ||
| 7 │ | ||
| 8 │ export default {}; | ||
| · ── | ||
| 9 │ </script> | ||
| ╰──── | ||
|
|
||
| × vue(no-export-in-script-setup): <script setup>` cannot contain ES module exports. | ||
| ╭─[src/example.vue:8:8] | ||
| 7 │ | ||
| 8 │ export default {}; | ||
| · ─────── | ||
| 9 │ </script> | ||
| ╰──── | ||
|
|
||
| × eslint(no-console): Unexpected console statement. | ||
| ╭─[src/example.vue:6:1] | ||
| 5 │ <script lang="ts" setup> | ||
| 6 │ console.log(); | ||
| · ─────────── | ||
| 7 │ | ||
| ╰──── | ||
| help: Delete this console statement. | ||
|
|
||
| Found 0 warnings and 4 errors. | ||
| Finished in <variable>ms on 2 files with <variable> rules using <variable> threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| console.log(); |
9 changes: 9 additions & 0 deletions
9
packages/cli/snap-tests/lint-override-semantic/src/example.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <template> | ||
| <div></div> | ||
| </template> | ||
|
|
||
| <script lang="ts" setup> | ||
| console.log(); | ||
|
|
||
| export default {}; | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "commands": ["vp lint src # extends rules are preserved when a file override adds Vue rules"] | ||
| } |
17 changes: 17 additions & 0 deletions
17
packages/cli/snap-tests/lint-override-semantic/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { defineConfig } from 'vite-plus'; | ||
|
|
||
| export default defineConfig({ | ||
| lint: { | ||
| rules: { 'no-console': 'error' }, | ||
| plugins: ['unicorn', 'eslint'], | ||
| overrides: [ | ||
| { | ||
| files: ['**/*.vue'], | ||
| plugins: ['vue'], | ||
| rules: { | ||
| 'vue/no-export-in-script-setup': 'error', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camc314 So
overridesconfig behave likeextendsinstead ofassign?cc @cpojer