chore(deps): bump vite-task to pick up the Windows ps1 stdin gate#1973
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
✅ Deploy Preview for viteplus-preview canceled.
|
fengmk2
added
test: e2e
vite-plus
@voidzero-dev/vite-plus-core
@voidzero-dev/vite-plus-prompts
@voidzero-dev/vite-plus-cli-darwin-arm64
@voidzero-dev/vite-plus-cli-darwin-x64
@voidzero-dev/vite-plus-cli-linux-arm64-gnu
@voidzero-dev/vite-plus-cli-linux-arm64-musl
@voidzero-dev/vite-plus-cli-linux-x64-gnu
@voidzero-dev/vite-plus-cli-linux-x64-musl
@voidzero-dev/vite-plus-cli-win32-arm64-msvc
@voidzero-dev/vite-plus-cli-win32-x64-msvc
@voidzero-dev/vite-plus-darwin-arm64
@voidzero-dev/vite-plus-darwin-x64
@voidzero-dev/vite-plus-linux-arm64-gnu
@voidzero-dev/vite-plus-linux-arm64-musl
@voidzero-dev/vite-plus-linux-x64-gnu
@voidzero-dev/vite-plus-linux-x64-musl
@voidzero-dev/vite-plus-win32-arm64-msvc
@voidzero-dev/vite-plus-win32-x64-msvc
commit: |
fengmk2
added a commit
to fengmk2/digital-signature
that referenced
this pull request
Jun 28, 2026
Pin vite-plus to the pkg.pr.new build of voidzero-dev/vite-plus#1973 (the Windows ps1 stdin-hang fix) via the catalog + overrides, and revert the workaround actions to stock (setup-vp@v1, tauri-apps/tauri-action@v0). If the Windows build now completes, the vp-side fix resolves the hang on its own, without the forked tauri-action stdin-close workaround.
Member
Author
|
The verification at fengmk2/digital-signature#1 was successful. |
fengmk2
added a commit
to fengmk2/redis-me
that referenced
this pull request
Jun 28, 2026
Pin vite-plus to the pkg.pr.new build of voidzero-dev/vite-plus#1973 (the Windows ps1 stdin-hang fix) via catalog + overrides, and revert the workaround actions to stock (setup-vp@v1, tauri-apps/tauri-action@v0). If the Windows build completes, the vp-side fix resolves the hang on its own.
Member
Author
|
voidzero-dev/vite-task#491 is merged (squash commit `6cfa6e47`), so the rev here is re-pinned from the branch commit to the merged Verified end-to-end with stock actions (upstream open-stdin
Both confirm the plan-time ps1 stdin gate resolves the Windows hang on its own, with no tauri-action/setup-vp workaround. |
vite-task's plan-time `.cmd` -> `powershell -File <.ps1>` rewrite was ungated and hung Windows CI builds (the `.ps1` wrappers block draining a non-TTY stdin pipe). vite-task@fix/ps1-stdin-tty-gate gates that rewrite on `is_stdin_terminal()`, matching vite_command's ps1_shim. Bumps the vite-task rev from 8daa9bb7 to 0c5c6236. Ref #1489
vite_command::ps1_shim and vite_task_plan::ps1_shim each had their own copy of the cached stdin-TTY gate. vite-task now hosts it once in the shared vite_powershell crate, so drop the local copy here and call the shared function. Bumps the vite-task rev to 0068d09b.
voidzero-dev/vite-task#491 merged to main as 6cfa6e47. Point the rev there (was the branch commit 0068d09b) so it tracks a permanent commit on main.
Member
Author
|
@codex review |
fengmk2
force-pushed
the
fix/windows-ps1-stdin-tty-gate
branch
from
2f78f93 to
d2abc1b
Compare
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
wan9chi
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vite-task's plan-time
.cmd->.ps1rewrite was ungated and hung Windows CI builds viavp run <script>(e.g.vp run tauri build): the.ps1wrappers block draining a non-TTY stdin pipe, so the process never exits after the build finishes and the runner waits on the open pipe until the job is cancelled hours later.Fix
Bump vite-task to
fix/ps1-stdin-tty-gate, which gates that rewrite onis_stdin_terminal()(matchingvite_command's ps1_shim). Rev8daa9bb7->0c5c6236.Depends on voidzero-dev/vite-task#491
Closes #1971