feat(check): support check.fmt/check.lint in vite.config.ts#1981
feat(check): support check.fmt/check.lint in vite.config.ts#1981fengmk2 wants to merge 5 commits into
Conversation
Mirror the `vp check --no-fmt` / `--no-lint` flags as persistent config so a project can make plain `vp check` skip formatting or linting by default, without anyone needing to remember a flag. - A step is skipped if config disables it or the matching flag is passed. - Config-based disabling only affects `vp check`; standalone `vp fmt` / `vp lint` and git-hook/staged are unaffected. - A short `note:` line is printed when config (not a flag) disables a step, for discoverability; CLI-flag output stays byte-identical.
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dda1de344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Dedup the JSON-bool accessor chain shared by the new check.fmt/check.lint reader and lint_config_type_check_enabled into a single json_bool(value, key, default) helper.
- Update stale check-all-skipped snapshot for the reworded summary line - Clarify docs: check.fmt/check.lint defaults apply to any vp check run, including one invoked from a pre-commit/staged hook - Note the typeAware prerequisite alongside typeCheck in check.lint guidance
This comment was marked as resolved.
This comment was marked as resolved.
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Adds a
checkblock tovite.config.tsthat mirrors thevp check --no-fmt/--no-lintflags, so a project can make plainvp checkskip formatting or linting by default.This is for teams that want most of the toolchain but not one step (e.g. lint only, no formatting), without anyone needing to remember a flag, and it keeps the generated AGENTS.md
vp checkguidance working as-is.Behavior:
vp check; standalonevp fmt/vp lintand git-hook/staged are unaffected.vp checkprints a shortnote:line for discoverability; existing CLI-flag output stays byte-identical.Verification: new snap fixtures (
check-config-no-fmt,check-config-no-lint,check-config-flag-precedence) and Rust unit tests for the config reader; existingcheck-*snaps unchanged;cargo clippy -p vite-plus-cliclean; manual runs confirm notes, scope, and the both-disabled error path.