Skip to content

Arithmetic Operations#8398

Draft
gatesn wants to merge 5 commits into
developfrom
ngates/arithmetic
Draft

Arithmetic Operations#8398
gatesn wants to merge 5 commits into
developfrom
ngates/arithmetic

Conversation

@gatesn

@gatesn gatesn commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

The only remaining calls to Arrow are for kleene logic, arithmetic, and LIKE expressions.

If we make these native Vortex, we can pull out Arrow into a vortex-arrow engine/integration crate.

gatesn added 3 commits June 12, 2026 15:58
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 22.2%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 31 improved benchmarks
❌ 7 regressed benchmarks
✅ 1507 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 20.7 µs 35.6 µs -41.91%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.9 µs 197.6 µs -18.08%
Simulation decompress_rd[f64, (100000, 0.1)] 845.9 µs 1,022.8 µs -17.3%
Simulation decompress_rd[f64, (100000, 0.01)] 845.9 µs 1,022.8 µs -17.29%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 177.1 µs 212.6 µs -16.68%
Simulation decompress_rd[f32, (100000, 0.01)] 498.4 µs 585.6 µs -14.9%
Simulation decompress_rd[f32, (100000, 0.1)] 498.4 µs 585.6 µs -14.9%
Simulation mul_i8_nonnull 456.4 µs 165.4 µs ×2.8
Simulation sub_i64_constant 1,070.9 µs 567.4 µs +88.75%
Simulation mul_i16_nonnull 546.5 µs 311.2 µs +75.59%
Simulation mul_i32_constant 675.3 µs 471.5 µs +43.22%
Simulation list_i32_large 332.6 µs 232.4 µs +43.09%
Simulation take_filter_list_small_uncached_random_mask_random_indices[256, 10] 192 µs 137.1 µs +40.05%
Simulation mul_i32_nonnull 726.1 µs 524.1 µs +38.54%
Simulation scalar_subtract 5.3 ms 3.9 ms +38.15%
Simulation take_filter_list_slice_mask_sequential_indices[768, 50] 158 µs 117.4 µs +34.54%
Simulation take_filter_list_slice_mask_sequential_indices[256, 50] 158.4 µs 118.1 µs +34.08%
Simulation take_filter_list_small_random_mask_random_indices[256, 10] 176.2 µs 134 µs +31.49%
Simulation take_filter_list_slice_mask_random_indices[256, 50] 178.1 µs 135.6 µs +31.41%
Simulation take_filter_list_small_random_mask_random_indices[768, 10] 180.2 µs 137.9 µs +30.64%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/arithmetic (74343cf) with develop (9444d20)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

gatesn added 2 commits June 12, 2026 18:40
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/performance A performance improvement label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant