fix: update stale route names and 404 assertions#16
Merged
Conversation
The `test` job on main was failing with 3 failures. The tests had drifted from the application. - `boot/routes.php` names the routes `api.home.index` and `api.home.about`, but the tests still expected `api.index` and `api.about`. - `respond_not_found()` returns the JSON error envelope from `error_response()` (`"message": "Not Found"` plus `path` and `method`), but the test looked for the string `Route not found`. Now asserts on the actual payload, including the requested path. Verified locally: `vendor/bin/phpunit` is 4/4 green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob on main was failing with 3 failures. The tests had drifted from the application.boot/routes.phpnames the routesapi.home.indexandapi.home.about, but the tests still expectedapi.indexandapi.about.respond_not_found()returns the JSON error envelope fromerror_response()("message": "Not Found"pluspathandmethod), but the test looked for the stringRoute not found. Now asserts on the actual payload, including the requested path.Verified locally:
vendor/bin/phpunitis 4/4 green.🤖 Generated with Claude Code