perf(client): use a Set for renewed module ids in logUpdates - #2375
Merged
Conversation
Replaces Array#includes inside the filter over updated modules (O(n·m) → O(n+m)) — noticeable on updates touching hundreds of modules.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Array#includes inside the filter over updated modules (O(n·m) → O(n+m)) — noticeable on updates touching hundreds of modules.
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
Note
Low Risk
Behavior-preserving micro-optimization in client HMR logging only; no auth, data, or API surface changes.
Overview
Hot-module-replacement logging now builds a
Setfrom successfully renewed module ids before filtering which updated modules were not accepted, instead of callingArray#includeson every id in the filter.That changes
logUpdatesfrom roughly O(n·m) to O(n+m) when comparing attempted vs renewed modules—mainly helpful when an update touches hundreds of modules, with the same warnings and reload behavior as before.Reviewed by Cursor Bugbot for commit 903995f. Bugbot is set up for automated code reviews on this repo. Configure here.