perf(hot): avoid idle work on the SSE stream - #2376
Open
bjohansebas wants to merge 1 commit into
Open
Conversation
- skip payload serialization in publish() when no client is connected, and cut the ProgressPlugin callback early via eventStream.hasClients() - start the heartbeat interval with the first client and stop it with the last one, instead of ticking forever - pair bundles against the previous build through a name-grouped Map, replacing the per-bundle filter (O(n²) → O(n)) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
Note
Low Risk
Performance-only changes in dev-middleware HMR; no auth or production build paths, with behavior unchanged when clients are connected.
Overview
Reduces CPU and timer work when no browser is connected to the HMR SSE endpoint, while keeping behavior the same once clients are attached.
The event stream starts the heartbeat on the first client and stops it on the last disconnect (instead of running
setIntervalcontinuously), exposeshasClients(), andpublish()returns early withoutJSON.stringifywhenclients.size === 0. Withprogressenabled, theProgressPlugincallback bails out when there are no clients before publishing percent updates.publishBundlesnow indexes previous bundles by name once and pairs by occurrence from that map, replacing a per-bundlefilterover the full previous list (O(n²) → O(n) for many child compilers).Reviewed by Cursor Bugbot for commit 8d375f2. Bugbot is set up for automated code reviews on this repo. Configure here.