Skip to content

feat(drive): Show viewer indicator (WPB-26396)#5059

Open
ohassine wants to merge 6 commits into
developfrom
show-viewer-indicator
Open

feat(drive): Show viewer indicator (WPB-26396)#5059
ohassine wants to merge 6 commits into
developfrom
show-viewer-indicator

Conversation

@ohassine

@ohassine ohassine commented Jul 15, 2026

Copy link
Copy Markdown
Member

https://wearezeta.atlassian.net/browse/WPB-26396


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Show view-only indicator for files in Drive

Screenshot_20260714_190004

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.46%. Comparing base (f15db33) to head (f4ef225).

Files with missing lines Patch % Lines
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% 4 Missing ⚠️
.../wire/android/feature/cells/ui/model/CellNodeUi.kt 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5059   +/-   ##
========================================
  Coverage    49.45%   49.46%           
========================================
  Files          655      655           
  Lines        23714    23725   +11     
  Branches      3660     3661    +1     
========================================
+ Hits         11728    11735    +7     
- Misses       10891    10895    +4     
  Partials      1095     1095           
Files with missing lines Coverage Δ
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 97.82% <100.00%> (+0.15%) ⬆️
.../com/wire/android/feature/cells/ui/CellListItem.kt 0.00% <ø> (ø)
...wire/android/feature/cells/ui/CellScreenContent.kt 0.00% <ø> (ø)
.../wire/android/feature/cells/ui/model/CellNodeUi.kt 90.00% <80.00%> (-0.59%) ⬇️
...n/com/wire/android/ui/home/HomeViewModelFactory.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15db33...f4ef225. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant