fix: WPB-25750 Enable passing cspExtraConnectSrc value to nginx-ingress-services#5236
Open
mohitrajain wants to merge 9 commits into
Open
fix: WPB-25750 Enable passing cspExtraConnectSrc value to nginx-ingress-services#5236mohitrajain wants to merge 9 commits into
mohitrajain wants to merge 9 commits into
Conversation
zebot
added
the
ok-to-test
mohitrajain
changed the title
smatting
approved these changes
May 21, 2026
Contributor
|
Approved. Note that I introduced a failure here which will make the integration tests fail for this PR. I think we should ignore this failure and merge this PR anyway, because
|
mohitrajain
force-pushed
the
wpb-25750-cspExtraConnect-multiIng
branch
from
June 24, 2026 14:04
2f7433c to
a65b495
Compare
…ss-services when working with multi-ingresses
mohitrajain
force-pushed
the
wpb-25750-cspExtraConnect-multiIng
branch
from
July 15, 2026 14:16
e327e8f to
372bad8
Compare
Contributor
|
I would ask @smatting to review again as there are significant amount of commits after his first approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable passing cspExtraConnectSrc value to nginx-ingress-services when working with multi-ingresses (renderCSPInIngress=True). It would be required for webapp to connect to third party sft servers.
Checklist
changelog.d