Skip to content

wolfHSM quickfix#789

Merged
dgarske merged 1 commit into
wolfSSL:masterfrom
bigbrett:wolfhsm-remove-pem-to-der
Jun 8, 2026
Merged

wolfHSM quickfix#789
dgarske merged 1 commit into
wolfSSL:masterfrom
bigbrett:wolfhsm-remove-pem-to-der

Conversation

@bigbrett

@bigbrett bigbrett commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Remove unnecessary WOLFSSL_PEM_TO_DER dependency to reduce code size

@bigbrett bigbrett self-assigned this Jun 5, 2026
Copilot AI review requested due to automatic review settings June 5, 2026 18:11

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #789

Scan targets checked: none
Failed targets: wolfboot-bugs, wolfboot-src

⚠️ Review incomplete — one or more scan targets failed before findings could be produced. See the Fenrir PR review detail page for logs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes an unused wolfSSL build-time feature flag (WOLFSSL_PEM_TO_DER) from user settings to reduce compiled code size.

Changes:

  • Drops WOLFSSL_PEM_TO_DER from include/user_settings.h configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bigbrett bigbrett assigned dgarske and unassigned bigbrett Jun 8, 2026
@bigbrett bigbrett requested a review from dgarske June 8, 2026 16:54
@bigbrett bigbrett requested a review from danielinux June 8, 2026 16:54
@dgarske dgarske merged commit a296902 into wolfSSL:master Jun 8, 2026
393 of 394 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants