add note about idempotency in ims_create_vlans and ims_remove_vlans#116
Open
gertvdw wants to merge 1 commit into
Open
add note about idempotency in ims_create_vlans and ims_remove_vlans#116gertvdw wants to merge 1 commit into
gertvdw wants to merge 1 commit into
Conversation
Mark90
reviewed
Jul 1, 2026
| def ims_remove_vlans(subscription: L2vpn) -> None: | ||
| """Note: this step is not idempotent. | ||
| If you want to use this workflow, this step has to be | ||
| refactored to make it idempotent.""" |
Contributor
There was a problem hiding this comment.
There was another comment lower in the ticket which you probably didn't see:
Please add a section on idempotency to the readme and point to the code.
So somewhere in an appropriate place in the readme we'd like to have a small section about idempotency of steps, and what that entails (without too much detail)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #62.
Warn about lack of idempotency in
ims_create_vlansandims_remove_vlans