Feature/sqlite compiletime#1180
Conversation
|
Hi, as mentioned, will you do the standard library pendant? (provide api functions) else this isn't publicly usable unless users define @extern natives by themselves? |
c31188a to
4eabb8b
Compare
|
Updated this PR with the clean implementation (including handle validation, statement connection ownership tracking, auto-finalizing open statements when closing connections, and explicit interpreter error messages). Also opened the WurstStdlib2 PR providing the native |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1742a4fbd7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d03161c to
5d16740
Compare
5d16740 to
6e51eb3
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e51eb3786
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ResultSet rs = sqliteResultSets.remove(statement.getVal()); | ||
| if (rs != null) rs.close(); | ||
| sqliteExecutedStatements.remove(statement.getVal()); | ||
| stmt.clearParameters(); |
There was a problem hiding this comment.
When a prepared statement with bound parameters is reset and stepped again without rebinding every parameter, this line clears all JDBC bindings. SQLite's reset operation leaves bindings in place, so common reuse patterns like binding a WHERE parameter once, reading a row, calling sqlite_reset(stmt), and stepping again silently query with NULL/no values or fail constraints instead of reusing the previous values. Please reset execution state without clearing bindings; expose a separate clear-bindings operation if needed.
Useful? React with 👍 / 👎.
2 participants
This PR adds compiletime support for sqlite operations. Not thoroughly tested, but simple stuff works:
Self-contained Examples:
SQLite.txt
SQLiteHelder.txt