Skip to content

Update for queue message API changes#28

Merged
samdark merged 2 commits into
masterfrom
fix-queue-message-api
Jul 9, 2026
Merged

Update for queue message API changes#28
samdark merged 2 commits into
masterfrom
fix-queue-message-api

Conversation

@samdark

@samdark samdark commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

  • update DB adapter to latest queue message API and MessageStatus
  • target yiisoft/db 2 and update the queue table update call
  • use queue delay metadata from DelayEnvelope
  • fix channel mutex recreation and add adapter tests
  • remove stale PHPUnit --no-interaction option from the test script

Tests

  • composer test
  • vendor/bin/psalm --config=psalm.xml --php-version=8.1
  • composer validate --strict

Copilot AI review requested due to automatic review settings July 9, 2026 08:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DB queue adapter to match the latest yiisoft/queue message APIs and yiisoft/db v2, adds adapter-focused tests, and adjusts dev dependencies/scripts accordingly.

Changes:

  • Updated Adapter to use the new message meta API (getMeta()), MessageStatus, and DelayEnvelope delay metadata.
  • Adjusted DB interactions for yiisoft/db v2 (notably the queue table update call) and fixed channel mutex recreation in withChannel().
  • Added PHPUnit adapter tests and updated Composer dependencies and the test script.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/Adapter.php Adapts queue adapter to new queue/message APIs and yiisoft/db v2; fixes mutex recreation; updates status handling.
tests/AdapterTest.php Adds unit tests covering push metadata/id behavior and withChannel() mutex recreation.
composer.json Bumps yiisoft/db to ^2.0, adds dev deps, and removes --no-interaction from the test script.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Adapter.php
Comment thread src/Adapter.php
Comment thread tests/AdapterTest.php Outdated
Comment thread tests/AdapterTest.php
Comment thread tests/AdapterTest.php Outdated
@samdark samdark merged commit c59fa43 into master Jul 9, 2026
17 checks passed
@samdark samdark deleted the fix-queue-message-api branch July 9, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants