Update for queue message API changes#28
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the DB queue adapter to match the latest yiisoft/queue message APIs and yiisoft/db v2, adds adapter-focused tests, and adjusts dev dependencies/scripts accordingly.
Changes:
- Updated
Adapterto use the new message meta API (getMeta()),MessageStatus, andDelayEnvelopedelay metadata. - Adjusted DB interactions for yiisoft/db v2 (notably the queue table update call) and fixed channel mutex recreation in
withChannel(). - Added PHPUnit adapter tests and updated Composer dependencies and the test script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/Adapter.php |
Adapts queue adapter to new queue/message APIs and yiisoft/db v2; fixes mutex recreation; updates status handling. |
tests/AdapterTest.php |
Adds unit tests covering push metadata/id behavior and withChannel() mutex recreation. |
composer.json |
Bumps yiisoft/db to ^2.0, adds dev deps, and removes --no-interaction from the test script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests