Timeline 2.0: optimize timeline feed pipeline#135
Open
ymichael wants to merge 1 commit into
Open
Conversation
18571a6 to
a37c675
Compare
a37c675 to
12d93e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bb/thread-view, collapse normal server feed generation toevents -> TimelineRow -> TimelineFeedRow, and keep the app/CLI compatibility adapter at the render boundaryValidation
git diff --checkpnpm exec turbo run typecheck --filter=@bb/server --filter=@bb/thread-view --filter=@bb/app --filter=@bb/server-contract --filter=@bb/db --filter=@bb/integration-tests --filter=@bb/cli --filter=@bb/sdkpnpm exec turbo run test --filter=@bb/serverpnpm exec turbo run test --filter=@bb/dbpnpm exec turbo run test --filter=@bb/thread-viewpnpm exec turbo run test --filter=@bb/app -- --run src/views/thread-detail/useThreadTimelinePages.test.ts src/components/thread/timeline/timeline-auto-expand.test.ts src/hooks/realtime-cache-effects.test.ts src/hooks/cache-owners/cache-owner-registry.test.ts src/hooks/queries/query-helpers.test.tsNotes
TimelineFeedRow -> TimelineFeedViewRowadapter is client-side render compatibility code, not part of the server query/generation hot path.