fix: accept unknown metadata fields with must_understand=false#4050
Open
NIK-TIGER-BILL wants to merge 1 commit into
Open
fix: accept unknown metadata fields with must_understand=false#4050NIK-TIGER-BILL wants to merge 1 commit into
NIK-TIGER-BILL wants to merge 1 commit into
Conversation
Fixes zarr-developers#3523 Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4050 +/- ##
==========================================
+ Coverage 93.53% 93.54% +0.01%
==========================================
Files 88 88
Lines 11894 11913 +19
==========================================
+ Hits 11125 11144 +19
Misses 769 769
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the Zarr specification, metadata with unknown fields that have
must_understand: falseshould be accepted. Currently, all unknown fields are rejected.Changes
must_understandis explicitly set tofalse.Testing
must_understand: falseis accepted.Fixes #3523