Skip to content

fix: accept unknown metadata fields with must_understand=false#4050

Open
NIK-TIGER-BILL wants to merge 1 commit into
zarr-developers:mainfrom
NIK-TIGER-BILL:fix/issue-3523
Open

fix: accept unknown metadata fields with must_understand=false#4050
NIK-TIGER-BILL wants to merge 1 commit into
zarr-developers:mainfrom
NIK-TIGER-BILL:fix/issue-3523

Conversation

@NIK-TIGER-BILL

Copy link
Copy Markdown
Contributor

Summary

Per the Zarr specification, metadata with unknown fields that have must_understand: false should be accepted. Currently, all unknown fields are rejected.

Changes

  • Updated metadata parsing to accept unknown fields when must_understand is explicitly set to false.

Testing

  • Added unit test verifying that metadata with unknown fields and must_understand: false is accepted.

Fixes #3523

Fixes zarr-developers#3523

Signed-off-by: NIK-TIGER-BILL <nik.tiger.bill@github.com>
@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.54%. Comparing base (b9d3964) to head (f794ca4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
+ Coverage   93.53%   93.54%   +0.01%     
==========================================
  Files          88       88              
  Lines       11894    11913      +19     
==========================================
+ Hits        11125    11144      +19     
  Misses        769      769              
Files with missing lines Coverage Δ
src/zarr/core/group.py 95.30% <100.00%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metadata parsing rejects zarr metadata with unknown fields

1 participant