Remove Inovelli entities#802
Draft
TheJulianJES wants to merge 1 commit into
Draft
Conversation
4 tasks
zigpy-review-bot
force-pushed
the
zigpy-bot/inovelli-drop-hardcoded-entities
branch
from
000d9e5 to
1ec2141
Compare
The Inovelli VZM switch/select/number/sensor configuration entities were hard-coded in the ZHA library and matched on the Inovelli manufacturer cluster (0xFC31). They are now declared by the zha-quirks v2 device handlers (InovelliQuirkBuilder), so the library copies are removed to avoid creating duplicate entities. The quirks v2 entities reuse the exact unique_ids these classes produced (suffix "64561-<attribute>"), so existing Home Assistant entities are preserved. The Inovelli virtual bind/init entities and the INOVELLI_CLUSTER constant are kept. Regenerated the Inovelli device snapshots (entity classes change from the removed Inovelli* classes to the generic quirks v2 entity classes; unique_ids are unchanged) and added VZM32-SN and VZM36 snapshots. Requires a zha-quirks release containing the Inovelli v2 entity port; this must land in the same ZHA release that bumps the zha-quirks pin.
zigpy-review-bot
force-pushed
the
zigpy-bot/inovelli-drop-hardcoded-entities
branch
from
1ec2141 to
0f53bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT. Tests currently only pass with ZHA changes. Diagnostics for the devices will be added in another PR for a cleaner diff.
Proposed change
The Inovelli VZM switch/select/number/sensor configuration entities were hard-coded in the ZHA library and matched on the Inovelli manufacturer cluster (0xFC31). They are now declared by the zha-quirks v2 device handlers (InovelliQuirkBuilder), so the library copies are removed to avoid creating duplicate entities.
The quirks v2 entities reuse the exact unique_ids these classes produced (suffix "64561-"), so existing Home Assistant entities are preserved. The Inovelli virtual bind/init entities and the INOVELLI_CLUSTER constant are kept.
Regenerated the inovelli-vzm30/31/35 device snapshots (entity classes change from the removed Inovelli* classes to the generic quirks v2 entity classes; unique_ids are unchanged) and added snapshots for VZM32-SN and VZM36.
Requires a zha-quirks release containing the Inovelli v2 entity port; this must land in the same ZHA release that bumps the zha-quirks pin.
Corresponding quirks PR(s):