Merge info_object into state and emit state change diffs#804
Draft
puddly wants to merge 9 commits into
Draft
Conversation
Clean up typing a little
This reverts commit 799d88c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
statedict with a strongly typed dataclass that absorbsinfo_object. We now also emit state change diffs inEntityStateChangedEvent's newstate_diffattribute.For stronger typing and to support the client/server architecture split in the future, we benefit from having more centralized state for entities. This will allow us to send batched state updates to the client instead of the client being notified of a general "update" and then reaching for the
statedict of the ZHA entity.The HA Core half is here: home-assistant/core@dev...puddly:core:puddly/zha-state-migration. It uses the
state_diffvalues and also adds dynamic capability recomputation.Part of OpenHomeFoundation/roadmap#93 and a continuation of #663.