[ENG-1960] Prevent node tag menu from stacking on repeated hotkey presses#1187
Merged
trangdoan982 merged 2 commits intoJul 8, 2026
Conversation
… presses Track the active popover in a closure variable inside setupNodeTagHotkey so that pressing the hotkey while a menu is already open closes it first and reopens at the new cursor position, rather than stacking another instance. Fixes ENG-1960. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
trangdoan982
changed the title
Promote the activePopover tracking variable to a class field so onunload() can call close() on it, cleaning up the DOM element and document-level event listeners if the plugin is unloaded while a NodeTagSuggestPopover or InlineNodeTypePicker is open. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
mdroidian
approved these changes
Jul 5, 2026
trangdoan982
deleted the
eng-1960-node-tags-menu-opens-multiple-times-when-hotkey-pressed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/e13d8f61cf924fa199da98f64d758291
Summary
setupNodeTagHotkey()usedEditorView.domEventHandlerswhich fires once per open editor pane; each invocation created a fresh popover instance, bypassing theif (this.popover)guard (which only checks the same object instance)setupNodeTagHotkey(); on each hotkey press, close the existing popover first (properly cleaning up its DOM element and document-level event listeners), then open a fresh one at the current cursor positionFixes ENG-1960
Test plan
🤖 Generated with Claude Code