Skip to content

[ENG-1960] Prevent node tag menu from stacking on repeated hotkey presses #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trangdoan982 merged 2 commits into from
Jul 8, 2026
+11 −2
Merged

[ENG-1960] Prevent node tag menu from stacking on repeated hotkey presses #1187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b77831
fix(obsidian): prevent node tag menu from stacking on repeated hotkey…
trangdoan982 Jul 3, 2026
792be4b
fix(obsidian): close active node popover on plugin unload
trangdoan982 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/obsidian/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ export default class DiscourseGraphPlugin extends Plugin {
settings: Settings = { ...DEFAULT_SETTINGS };
private tagNodeHandler: TagNodeHandler | null = null;
private fileChangeListener: FileChangeListener | null = null;
private activeNodePopover:
| NodeTagSuggestPopover
| InlineNodeTypePicker
| null = null;
private currentViewActions: { leaf: WorkspaceLeaf; action: HTMLElement }[] =
[];
private pendingCanvasSwitches = new Set<string>();
Expand Down Expand Up @@ -293,26 +297,29 @@ export default class DiscourseGraphPlugin extends Plugin {
event.preventDefault();
event.stopPropagation();

this.activeNodePopover?.close();
this.activeNodePopover = null;

const activeView = this.app.workspace.getActiveViewOfType(MarkdownView);
if (activeView?.editor) {
const editor = activeView.editor;
const selectedText = editor.getSelection();

if (selectedText && selectedText.trim().length > 0) {
// Text is selected: open node type picker to create node from selection
const picker = new InlineNodeTypePicker({
editor,
nodeTypes: this.settings.nodeTypes,
plugin: this,
selectedText: selectedText.trim(),
});
this.activeNodePopover = picker;
picker.open();
} else {
// No selection: open the candidate node tag popover
const popover = new NodeTagSuggestPopover(
editor,
this.settings.nodeTypes,
);
this.activeNodePopover = popover;
popover.open();
}
}
Expand Down Expand Up @@ -430,6 +437,8 @@ export default class DiscourseGraphPlugin extends Plugin {
}

onunload() {
this.activeNodePopover?.close();
this.activeNodePopover = null;
this.cleanupViewActions();
activeDocument.body.classList.remove("dg-hide-frontmatter-ids");

Expand Down