Skip to content

Accept boolean fftconvolve axes in PyTorch backend#3681

Open
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fftconvolve-bool-axes
Open

Accept boolean fftconvolve axes in PyTorch backend#3681
FlorianPfaff wants to merge 2 commits into
mainfrom
fix-pytorch-fftconvolve-bool-axes

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • Accept boolean scalar axes values in the PyTorch signal.fftconvolve axis coercion path by using the scalar __index__ protocol.
  • Match SciPy behavior for axes=False and preserve bounds validation for axes=True on 1D inputs.
  • Add a regression test covering boolean scalar axes.

Testing

  • Not run locally; the execution sandbox could not clone GitHub, so this patch was applied through the GitHub connector and should be validated by PR CI.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 2, 2026 10:52
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 80.69s
✅ JSON prettier 7 0 0 0 1.03s
✅ JSON v8r 7 0 0 4.29s
✅ MARKDOWN markdownlint 68 0 0 0 1.94s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.73s
✅ PYTHON black 1195 32 0 0 68.68s
✅ PYTHON isort 1195 61 0 0 5.83s
✅ REPOSITORY checkov yes no no 51.0s
✅ REPOSITORY gitleaks yes no no 12.19s
✅ REPOSITORY git_diff yes no no 0.21s
✅ REPOSITORY secretlint yes no no 50.18s
✅ REPOSITORY syft yes no no 5.17s
✅ REPOSITORY trivy-sbom yes no no 6.03s
✅ REPOSITORY trufflehog yes no no 19.75s
✅ YAML prettier 11 0 0 0 0.82s
✅ YAML v8r 11 0 0 11.94s
✅ YAML yamllint 11 0 0 0.65s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant