Skip to content

Accept boolean fftconvolve axes in PyTorch backend #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlorianPfaff wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Accept boolean fftconvolve axes in PyTorch backend #3681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d97768
Accept boolean scalar fftconvolve axes
FlorianPfaff Jul 2, 2026
3eb5b0f
Test boolean fftconvolve axes contract
FlorianPfaff Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/pyrecest/_backend/pytorch/signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ def _coerce_axis(axis):
axis_array = _np.asarray(axis)
except (TypeError, ValueError) as exc:
raise TypeError(_AXIS_TYPE_ERROR) from exc
if axis_array.shape != () or axis_array.dtype.kind not in "iu":
if axis_array.shape != ():
raise TypeError(_AXIS_TYPE_ERROR)
return int(axis_array.item())
try:
return int(axis_array.item().__index__())
except AttributeError as exc:
raise TypeError(_AXIS_TYPE_ERROR) from exc


def _is_scalar_axis_argument(value):
Expand Down
15 changes: 15 additions & 0 deletions tests/backend_support/test_pytorch_fftconvolve_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,21 @@ def test_pytorch_fftconvolve_scalar_empty_axes_matches_scipy():
assert np.allclose(actual, expected)


def test_pytorch_fftconvolve_boolean_axes_match_scipy():
if backend.__backend_name__ != "pytorch":
pytest.skip("PyTorch-specific signal backend contract")

first = backend.asarray([1.0, 2.0])
second = backend.asarray([3.0, 4.0])

actual = _as_numpy(backend.signal.fftconvolve(first, second, axes=False))
expected = scipy_fftconvolve(_as_numpy(first), _as_numpy(second), axes=False)

assert np.allclose(actual, expected)
with pytest.raises(ValueError, match="out of bounds"):
backend.signal.fftconvolve(first, second, axes=True)


def test_pytorch_fft_helpers_accept_array_like_inputs():
if backend.__backend_name__ != "pytorch":
pytest.skip("PyTorch-specific FFT backend contract")
Expand Down
Loading