chore: [SDK-4213] remove background-threading feature flag from threading core (part 1/3)#2672
Open
abdulraqeeb33 wants to merge 1 commit into
Open
chore: [SDK-4213] remove background-threading feature flag from threading core (part 1/3)#2672abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
…ding core (part 1/3) Foundation of the SDK-4213 stack. Removes the background-threading feature flag and ThreadingMode so async dispatch is unconditional: strips the flag from ThreadUtils, FeatureFlag, FeatureManager, and FeatureFlagsRefreshService, and hardens OneSignalDispatchers (per-generation pools, prewarm). Updates the affected unit tests and adds ThreadUtilsDispatchTests + test project config. Part 1 of 3. Merge before part 2. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of 3 of the SDK-4213 background-threading feature-flag removal, split into a stack for easier review/merge.
This part is the foundation: it removes the background-threading feature flag and
ThreadingModeso async dispatch is unconditional.ThreadUtils,FeatureFlag,FeatureManager,FeatureFlagsRefreshService.OneSignalDispatchers(per-generation pools, prewarm).ThreadUtilsDispatchTests+ test project config; deletesThreadUtilsFeatureFlagTests.Stack (merge in order)
mainar/sdk-4213-part1ar/sdk-4213-part2Test plan
:corethreading unit tests passMade with Cursor