chore: [SDK-4213] make async init the default in OneSignalImp + startup (part 2/3)#2673
Open
abdulraqeeb33 wants to merge 1 commit into
Open
chore: [SDK-4213] make async init the default in OneSignalImp + startup (part 2/3)#2673abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
…up (part 2/3) Builds on part 1. Drops the feature-flag branching from initialization: OneSignalImp now always runs init asynchronously on the dispatcher pool, with the suspend/blocking wait paths kept consistent, and removes the dead getServiceWithFeatureGate pass-through. StartupService no longer gates on the flag. Updates SDKInitTests, OneSignalImpTests, and StartupServiceTests. Part 2 of 3. Stacked on part 1; merge after part 1. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2 of 3 of the SDK-4213 stack. Stacked on #2672 — review/merge after part 1.
Drops feature-flag branching from initialization:
OneSignalImpalways runs init asynchronously on the dispatcher pool; suspend/blocking wait paths kept consistent.getServiceWithFeatureGatepass-through.StartupServiceno longer gates on the flag.SDKInitTests,OneSignalImpTests,StartupServiceTests.Test plan
Made with Cursor