Auth: wire Spring Security + Spring Session JDBC end to end - #47
Open
RandyJDean wants to merge 1 commit into
Conversation
This was referenced Jul 9, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+76
to
+78
| .orElseGet(() -> { | ||
| invalidateSession(httpRequest); | ||
| return ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(ApiResponder.failure("Not signed in")); |
There was a problem hiding this comment.
Missing SecurityContextHolder.clearContext() call when member not found. If a member is deleted from the database while their session is still active, the session gets invalidated but the SecurityContext remains in the thread-local for the duration of this request. This could allow subsequent code in the same request to still see an authenticated principal that should no longer exist.
.orElseGet(() -> {
invalidateSession(httpRequest);
SecurityContextHolder.clearContext(); // Add this line
return ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(ApiResponder.failure("Not signed in"));
});Note that the logout() method at line 86 correctly clears the context after invalidation.
Suggested change
| .orElseGet(() -> { | |
| invalidateSession(httpRequest); | |
| return ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(ApiResponder.failure("Not signed in")); | |
| .orElseGet(() -> { | |
| invalidateSession(httpRequest); | |
| SecurityContextHolder.clearContext(); | |
| return ResponseEntity.status(HttpStatus.UNAUTHORIZED).body(ApiResponder.failure("Not signed in")); | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
arklian
reviewed
Jul 10, 2026
| /** Answers unauthenticated requests to protected endpoints with a 401 in the standard JSON envelope. */ | ||
| @Component | ||
| @RequiredArgsConstructor | ||
| public class ApiAuthenticationEntryPoint implements AuthenticationEntryPoint { |
Member
There was a problem hiding this comment.
Would be good to add an example of how to protect an endpoint.
RandyJDean
force-pushed
the
07-09-auth_wire_spring_security_spring_session_jdbc_end_to_end
branch
from
July 31, 2026 17:24
37bcb7f to
81d33d2
Compare
RandyJDean
force-pushed
the
07-09-auth_request-link_and_verify_flows
branch
from
July 31, 2026 17:24
9ebd548 to
2a9e88a
Compare
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/31/26)2 reviewers were added to this PR based on Henry Chen's automation. |
- AuthController: POST /api/auth/request-link|verify|logout and GET /api/session; verify performs programmatic login (session id rotation + SecurityContextRepository save), session reads the member fresh so profile completion is never stale - SecurityConfig moved to auth/security and rewired: patchats_session cookie (HttpOnly, SameSite=Lax, Secure per profile, 30d) via DefaultCookieSerializer; dev/prod chains share CSRF-off posture documented in the javadoc; prod email rule kept fail-closed - ApiAuthenticationEntryPoint answers 401s in the ApiResponder envelope - AuthenticatedMember principal is Serializable (persisted by Spring Session) and exposes email as the indexed principal name - SecurityWiringTest exercises the real filter chain: anonymous 401, session-carried auth across requests, logout invalidation Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RandyJDean
force-pushed
the
07-09-auth_wire_spring_security_spring_session_jdbc_end_to_end
branch
from
July 31, 2026 18:17
81d33d2 to
3c0452c
Compare
RandyJDean
force-pushed
the
07-09-auth_request-link_and_verify_flows
branch
from
July 31, 2026 18:17
2a9e88a to
04a095e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /api/session; verify performs programmatic login (session id
rotation + SecurityContextRepository save), session reads the member
fresh so profile completion is never stale
cookie (HttpOnly, SameSite=Lax, Secure per profile, 30d) via
DefaultCookieSerializer; dev/prod chains share CSRF-off posture
documented in the javadoc; prod email rule kept fail-closed
Session) and exposes email as the indexed principal name
session-carried auth across requests, logout invalidation
Co-Authored-By: Claude Fable 5 noreply@anthropic.com