Auth: enable CSRF protection (SPA double-submit pattern) - #51
Open
RandyJDean wants to merge 1 commit into
Conversation
This was referenced Jul 10, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
RandyJDean
marked this pull request as ready for review
July 10, 2026 18:47
RandyJDean
force-pushed
the
07-09-auth_fix_verify_page_stuck_on_spinner_under_strictmode
branch
from
July 31, 2026 17:24
2576e29 to
874f7c4
Compare
RandyJDean
force-pushed
the
07-09-auth_enable_csrf_protection_spa_double-submit_pattern_
branch
from
July 31, 2026 17:24
af31d22 to
88624f3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (07/31/26)2 reviewers were added to this PR based on Henry Chen's automation. |
CSRF was disabled on the SameSite=Lax + JSON-only rationale, but with a JDBC-backed session cookie the token machinery is the defense-in-depth norm (and security tooling rightly flags csrf.disable()). - CookieCsrfTokenRepository writes a JS-readable XSRF-TOKEN cookie on every response via SpaCsrfTokenRequestHandler (the Spring-documented SPA handler: BREACH-safe masking, raw header resolution) - apiFetch echoes the cookie as X-XSRF-TOKEN on state-changing requests - Pre-auth endpoints (request-link, verify) are exempt: their only credential is in the body and a first-time visitor has no CSRF cookie yet; logout and everything else require the token - SecurityWiringTest: token-less POST -> 403, logout with token -> 200 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RandyJDean
force-pushed
the
07-09-auth_fix_verify_page_stuck_on_spinner_under_strictmode
branch
from
July 31, 2026 18:17
874f7c4 to
f8279ce
Compare
RandyJDean
force-pushed
the
07-09-auth_enable_csrf_protection_spa_double-submit_pattern_
branch
from
July 31, 2026 18:17
88624f3 to
3553634
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSRF was disabled on the SameSite=Lax + JSON-only rationale, but with a
JDBC-backed session cookie the token machinery is the defense-in-depth
norm (and security tooling rightly flags csrf.disable()).
every response via SpaCsrfTokenRequestHandler (the Spring-documented
SPA handler: BREACH-safe masking, raw header resolution)
credential is in the body and a first-time visitor has no CSRF
cookie yet; logout and everything else require the token
Co-Authored-By: Claude Fable 5 noreply@anthropic.com