PR1706 follow-ups#1716
Merged
renkun-ken merged 2 commits intoJun 30, 2026
Merged
Conversation
profile.R is sourced as the user's R_PROFILE_USER, so the top-level plot_backend assignment created a stray variable in the user's global environment that persisted after startup (reported by @Fred-Wu). Wrap the sess::connect() setup in local() so the temporary plot_backend binding stays scoped, matching the pattern used by the .Rprofile block above it.
When r.plot.backend explicitly selects jgd or httpgd (or the legacy r.plot.useHttpgd is true) but the package is not installed, register_hooks silently fell back to the standard viewer. The standard viewer has no plot-cycling UI, so users saw a degraded experience with no explanation (several reports on REditorSupport#1706). Emit a warning from register_hooks naming the requested backend and the remedy, but only when a specific backend was explicitly requested. The auto mode (use_jgd && use_httpgd) still degrades silently by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor follow-ups to #1706:
plot_backendinto global R environment (H/T @Fred-Wu comment)