Skip to content

PR1706 follow-ups #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renkun-ken merged 2 commits into from
Jun 30, 2026
Merged

PR1706 follow-ups #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5b961
fix(plot): avoid leaking plot_backend into the global environment
grantmcdermott Jun 29, 2026
53abf19
feat(plot): warn when a requested plot backend is unavailable
grantmcdermott Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions R/profile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ local({
})

if (requireNamespace("sess", quietly = TRUE)) {
plot_backend <- Sys.getenv("SESS_PLOT_BACKEND", "auto")
sess::connect(
use_rstudioapi = as.logical(Sys.getenv("SESS_RSTUDIOAPI", "TRUE")),
use_httpgd = (plot_backend %in% c("auto", "httpgd")),
use_jgd = (plot_backend %in% c("auto", "jgd"))
)
local({
plot_backend <- Sys.getenv("SESS_PLOT_BACKEND", "auto")
sess::connect(
use_rstudioapi = as.logical(Sys.getenv("SESS_RSTUDIOAPI", "TRUE")),
use_httpgd = (plot_backend %in% c("auto", "httpgd")),
use_jgd = (plot_backend %in% c("auto", "jgd"))
)
})
}
20 changes: 20 additions & 0 deletions sess/R/hooks.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,26 @@ register_hooks <- function(use_rstudioapi = TRUE, use_httpgd = TRUE, use_jgd = F
notify_client("httpgd", list(url = httpgd::hgd_url()))
})
} else {
# If a specific interactive backend was explicitly requested but is
# unavailable, warn before silently degrading to the standard viewer.
# (use_jgd && use_httpgd means "auto", which is meant to degrade quietly.)
if (xor(use_jgd, use_httpgd)) {
if (use_jgd && !requireNamespace("jgd", quietly = TRUE)) {
warning("[sess] Plot backend \"jgd\" was requested but the jgd package ",
"is not installed. Falling back to the standard plot viewer. ",
"Install jgd, or change the r.plot.backend setting.", call. = FALSE)
} else if (use_jgd) {
warning("[sess] Plot backend \"jgd\" was requested but no renderer ",
"connection is available. Falling back to the standard plot ",
"viewer.", call. = FALSE)
} else if (use_httpgd) {
warning("[sess] Plot backend \"httpgd\" was requested but the httpgd ",
"package is not installed. Falling back to the standard plot ",
"viewer. Install httpgd, or change the r.plot.backend setting.",
call. = FALSE)
}
}

# Default to static plot capturing (Re-implementation based on legacy plot handler)
plot_file <- .sess_env$latest_plot_path
file.create(plot_file, showWarnings = FALSE)
Expand Down
Loading