[Phase 10] Add Swift E2E target - #466
Conversation
|
✅ Checkout Kit E2E failures resolved. |
ead8b5f to
a6a04e0
Compare
4a6f480 to
f0246d0
Compare
a6a04e0 to
5e13572
Compare
5e13572 to
483db53
Compare
f0246d0 to
291c33b
Compare
5084a63 to
1803629
Compare
1803629 to
fb39879
Compare
| -sdk iphoneos \ | ||
| -destination generic/platform=iOS \ | ||
| -archivePath "$archive_path" \ | ||
| "CODE_SIGNING_ALLOWED=NO" \ |
There was a problem hiding this comment.
AI assisted question:
e2e_build_ios_device_ipa() passes CODE_SIGNING_ALLOWED=NO / CODE_SIGNING_REQUIRED=NO to xcodebuild archive and defers all signing to the later -exportArchive step via the generated exportOptionsPlist.
Previously, build_react_native_ios’s own archive_device_app() signed directly during xcodebuild archive (CODE_SIGN_STYLE=Manual, DEVELOPMENT_TEAM, CODE_SIGN_IDENTITY, PROVISIONING_PROFILE_SPECIFIER).
Since build_react_native_ios now sources this shared helper, the previously working react-native-ios CI signing path is changed by this refactor, it isn’t purely additive.
Have we tried unsigned-archive-then-signed-export sequence end-to-end for the react-native-ios Bitrise workflow?
There was a problem hiding this comment.
FWIW the reason I had to change around the code signing stage after including swift-ios because Apollo is installed via SPM and it was attempting to sign the apollo package (which failed)
By skipping it for the archive and then signing at export it circumvents attempting to sign third party deps
Merge activity
|


Stack Context
This is Phase 10 of the BrowserStack Maestro E2E stack for Checkout Kit, stacked on GitHub E2E reporting.
Parent issue: https://github.com/shop/issues-checkout-kit/issues/1149
Epic: https://github.com/shop/issues-checkout-kit/issues/1084
What changes are you making?
Adds the Swift sample app to the e2e test matrix
Adds an invisible e2e ready marker to assert against in line with what we do for react-native
How to test
Nothing to test - should just see the bitrise report a swift build now too
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.