Skip to content

[Phase 10] Add Swift E2E target - #466

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-feataddswifte2etest
Jul 15, 2026
Merged

[Phase 10] Add Swift E2E target#466
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/07-15-feataddswifte2etest

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Stack Context

This is Phase 10 of the BrowserStack Maestro E2E stack for Checkout Kit, stacked on GitHub E2E reporting.

Parent issue: https://github.com/shop/issues-checkout-kit/issues/1149
Epic: https://github.com/shop/issues-checkout-kit/issues/1084

What changes are you making?

Adds the Swift sample app to the e2e test matrix
Adds an invisible e2e ready marker to assert against in line with what we do for react-native

How to test

Nothing to test - should just see the bitrise report a swift build now too


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 15, 2026
@kieran-osgood-shopify kieran-osgood-shopify changed the title feat: add swift e2e test [Phase 10] Add Swift E2E target Jul 15, 2026
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review July 15, 2026 09:58
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner July 15, 2026 09:58
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.85% (327/356) 87.98% (183/208) 100% (86/86)

@bitrise

bitrise Bot commented Jul 15, 2026

Copy link
Copy Markdown

✅ Checkout Kit E2E failures resolved.

@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch from ead8b5f to a6a04e0 Compare July 15, 2026 11:33
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddandroidkotline2etesttarget branch from 4a6f480 to f0246d0 Compare July 15, 2026 11:33
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch from a6a04e0 to 5e13572 Compare July 15, 2026 11:38
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/07-15-feataddandroidkotline2etesttarget to graphite-base/466 July 15, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch from 5e13572 to 483db53 Compare July 15, 2026 13:41
@graphite-app
graphite-app Bot changed the base branch from graphite-base/466 to main July 15, 2026 13:42
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch 2 times, most recently from 5084a63 to 1803629 Compare July 15, 2026 14:25
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/07-15-feataddswifte2etest branch from 1803629 to fb39879 Compare July 15, 2026 15:03
-sdk iphoneos \
-destination generic/platform=iOS \
-archivePath "$archive_path" \
"CODE_SIGNING_ALLOWED=NO" \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI assisted question:

e2e_build_ios_device_ipa() passes CODE_SIGNING_ALLOWED=NO / CODE_SIGNING_REQUIRED=NO to xcodebuild archive and defers all signing to the later -exportArchive step via the generated exportOptionsPlist.

Previously, build_react_native_ios’s own archive_device_app() signed directly during xcodebuild archive (CODE_SIGN_STYLE=Manual, DEVELOPMENT_TEAM, CODE_SIGN_IDENTITY, PROVISIONING_PROFILE_SPECIFIER).

Since build_react_native_ios now sources this shared helper, the previously working react-native-ios CI signing path is changed by this refactor, it isn’t purely additive.

Have we tried unsigned-archive-then-signed-export sequence end-to-end for the react-native-ios Bitrise workflow?

@kieran-osgood-shopify kieran-osgood-shopify Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change to the e2e/** files triggers the e2e builds to re-run so the react native ios workflow ran as part of the CI for this branch and everything is continuing to work!

image.png

@kieran-osgood-shopify kieran-osgood-shopify Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the reason I had to change around the code signing stage after including swift-ios because Apollo is installed via SPM and it was attempting to sign the apollo package (which failed)

By skipping it for the archive and then signing at export it circumvents attempting to sign third party deps

kieran-osgood-shopify commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@kieran-osgood-shopify
kieran-osgood-shopify merged commit 9d7a6f1 into main Jul 15, 2026
35 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/07-15-feataddswifte2etest branch July 15, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants